feat: Support MediaType annotation#156
Merged
Merged
Conversation
daogrady
changed the title
tim-sh
requested changes
Jun 11, 2026
tim-sh
left a comment
tim-sh
left a comment
Member
There was a problem hiding this comment.
Looks solid. AI verified the logic against OData v4.01 §§11.2.3, 11.4.7, 11.4.8 and the oasis-tcs reference implementation…
Contributor
Author
|
@tim-sh thank you for the feedback! From what I can gather from the standard, your concerns are all valid. Again, I have recreated your suggestions locally to make sure you can still approve. |
tim-sh
previously approved these changes
Jun 11, 2026
tim-sh
left a comment
tim-sh
left a comment
Member
There was a problem hiding this comment.
Thanks for the quick follow-up – just a nit, the snapshot files (TripPin.openapi3.json, csdl-16.1.openapi3.json) lost their trailing newline it seems, but PR is fine to merge anyway.
Contributor
Author
|
@tim-sh good spot! I reintroduced them, which requires another approval, I'm afraid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 19862