feat: add sign message to example - #2242
Merged
Merged
Conversation
mjuchli-da
commented
Aug 6, 2026
mjuchli-da
commented
Contributor
Signed-off-by: Marc Juchli <marc.juchli@digitalasset.com>
There was a problem hiding this comment.
Pull request overview
Adds a new “Signing” feature to the examples/ping dApp so users can sign an arbitrary message via the wallet and view the returned signature payload.
Changes:
- Introduces a new
Signingcomponent that callssdk.dappSDK.signMessage({ message })and renders the result. - Wires the new component into
App.tsxas an additional tab shown when connected.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/ping/src/components/Signing.tsx | New UI + logic to sign a message and display the response (with loading + error handling). |
| examples/ping/src/App.tsx | Adds a “Signing” tab and mounts the new Signing component in the tab content area. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marc Juchli <120378272+mjuchli-da@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marc Juchli <120378272+mjuchli-da@users.noreply.github.com>
mjuchli-da
enabled auto-merge (squash)
August 6, 2026 13:36
pawelstepien-da
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.