fix: 1874 network connectivity UI - #2211
Conversation
mjuchli-da
left a comment
There was a problem hiding this comment.
@dhru7777 thank you for the contribution. It looks good.
Do you mind rebasing (resolving the conflicts)? Also note that the e2e test failed. This is likely due to the dapps expecting a different (still wrong) network state.
|
Yes, I’ll get it done. Thankyou
…On Wed, Aug 5, 2026 at 7:45 AM Marc Juchli ***@***.***> wrote:
***@***.**** commented on this pull request.
@dhru7777 <https://github.com/dhru7777> thank you for the contribution.
It looks good.
Do you mind rebasing (resolving the conflicts)? Also note that the e2e
test failed. This is likely due to the dapps expecting a different (still
wrong) network state.
—
Reply to this email directly, view it on GitHub
<#2211?email_source=notifications&email_token=BPUJQ6Q7725V7BIACWQLYGT5IMM6HA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBWGM4TONBVHEY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#pullrequestreview-4863974591>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BPUJQ6SHQHNFKMSTTQGMT4T5IMM6HAVCNFSNUABFKJSXA33TNF2G64TZHM4TSMZTGM2DEMBSHNEXG43VMU5TKMBSGE3DSMZZGY32C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BPUJQ6RWLAN64CU3IE2OBXT5IMM6HA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBWGM4TONBVHEY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BPUJQ6WE4SXHWQC67GYA7KT5IMM6HA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOBWGM4TONBVHEY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…ted badge Signed-off-by: dhru7777 <dheerajinnyc@gmail.com>
…tatus Signed-off-by: dhru7777 <dheerajinnyc@gmail.com>
e54b652 to
dea981d
Compare
|
Thanks for the review RebaseRebased onto latest
About the e2e failuresI investigated the earlier Local run (Canton + gateway + mock OAuth + ping, with
Those failure modes are OAuth callback / connect-settle races, not assertions on the header/network “CONNECTED” badge. This PR only drives that badge from Regarding your note that dapps may still expect the old (wrong) network state: the dApp’s Happy to dig further if CI still fails on the rebased commits, or if you’d prefer a follow-up for hardening the flaky multisession/settings paths. |
Summary
listSessions.statusinstead of storednetworkIdsession.status === 'connected'Test plan
listSessionsstatus/v2/version→ green dot + CONNECTED badgeScreenshots
Ledger Health Check Status



Green Dot
Ledger Health Check Failed - Grey Dot