feat(core-origin-manager): add origin check manager - #2183
Open
mateuszpiatkowski-da wants to merge 16 commits into
Open
feat(core-origin-manager): add origin check manager#2183mateuszpiatkowski-da wants to merge 16 commits into
mateuszpiatkowski-da wants to merge 16 commits into
Conversation
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
…add-origin-check Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
alexmatson-da
previously approved these changes
Jul 29, 2026
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
…add-origin-check Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
mateuszpiatkowski-da
changed the title
mateuszpiatkowski-da
changed the title
Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
mateuszpiatkowski-da
changed the title
mateuszpiatkowski-da
changed the title
…add-origin-check Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
alexmatson-da
approved these changes
Aug 5, 2026
| abstract class OriginManager { | ||
| protected allowedOrigins: Set<Location['origin']> = new Set() | ||
| protected abstract readonly messageToReceive: OriginHandshakeMessage | ||
| protected abstract readonly listenerCallback: (event: MessageEvent) => void |
Contributor
There was a problem hiding this comment.
nitpick, maybe rename to handshakeCallback for clarity
| /** | ||
| * Starts periodically broadcasting handshake messages to the child origin. | ||
| */ | ||
| public poll(origin: Location['origin'], intervalMs = 500) { |
Contributor
There was a problem hiding this comment.
another nitpick, I would maybe name this connect -- the polling is an implementation detail of connecting via the handshake
Contributor
There was a problem hiding this comment.
(nvm, ignore this comment if you decide to make .poll an internal detail instead of public, as per the comment below)
Comment on lines
+56
to
+72
| import { ParentWindowOriginManager } from '@canton-network/core-origin-check' | ||
|
|
||
| // Create a manager instance | ||
| const originManager = new ParentWindowOriginManager() | ||
|
|
||
| // Start polling for a specific origin | ||
| const childOrigin = 'https://child.example.com' | ||
| originManager.poll(childOrigin) | ||
|
|
||
| // Send a message using the safe postMessage method | ||
| // This will only succeed if the handshake is complete | ||
| originManager.postMessage({ type: 'greeting', data: 'hello' }, childOrigin) | ||
|
|
||
| // Or manually check before sending | ||
| if (originManager.assert(childOrigin)) { | ||
| window.postMessage(data, childOrigin) | ||
| } |
Contributor
There was a problem hiding this comment.
I think ideally the polling / handshake process is made invisible to the user, so they don't need to call .poll manually. ParentWindowOriginManager can probably track the connected status per origin, then
const originManager = new ParentWindowOriginManager()
const childOrigin = 'https://child.example.com'
// first time -- call `.poll` under the hood. throws any connection errors
originManager.postMessage({ type: 'greeting', data: 'hello' }, childOrigin)
// second time -- already connected, msg goes straight through
originManager.postMessage({ type: 'greeting': data: 'hello-2' }, childOrigin)
Comment on lines
+85
to
+90
| // Send a message using the safe postMessage method | ||
| // This will only succeed if the handshake is complete | ||
| const parentOrigin = window.opener?.location.origin | ||
| if (parentOrigin) { | ||
| originManager.postMessage({ type: 'response', data: 'world' }, parentOrigin) | ||
| } |
Contributor
There was a problem hiding this comment.
I would just move this check inside the implementation as well. The constructor could take an optional parentOrigin if the user wants to override it, but window.opener should be the default
Contributor
There was a problem hiding this comment.
actually window.opener.location is problematic because browsers block access to this field across origins. The child manager should just use the origin it got from the handshake as the parent origin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.