Skip to content

Ignore expired preapprovals in AcceptTransferPreapprovalProposalTrigger - #6673

Open
moritzkiefer-da wants to merge 2 commits into
mainfrom
cocreature/accept-expired-preapproval
Open

Ignore expired preapprovals in AcceptTransferPreapprovalProposalTrigger#6673
moritzkiefer-da wants to merge 2 commits into
mainfrom
cocreature/accept-expired-preapproval

Conversation

@moritzkiefer-da

Copy link
Copy Markdown
Contributor

[ci]

fixes #6610

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

[ci]

fixes #6610

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org
Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
@moritzkiefer-da
moritzkiefer-da force-pushed the cocreature/accept-expired-preapproval branch from fa62f9b to 86b9069 Compare August 5, 2026 12:54
@moritzkiefer-da
moritzkiefer-da marked this pull request as ready for review August 5, 2026 12:54

@julientinguely-da julientinguely-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

[ci]

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept TransferPreapprovalProposal if the existing one is expired

3 participants