Remove Scan app enableAppActivityRecordAndTrafficIngestion and serveAppActivityRecordsAndTraffic config options - #6643
Conversation
c207126 to
8ce5059
Compare
| // Sequencer is returning TRAFFIC_CONTROL_DISABLED when looking up traffic summaries. | ||
| config.copy(enableAppActivityRecordAndTrafficIngestion = false) | ||
| )(config) | ||
| ) |
There was a problem hiding this comment.
This was added and discussed in #4968 (comment). I wasn't able to reproduce the error, so my hunch is that a Canton update since then resolved it.
There was a problem hiding this comment.
Well if this fails on CI then we would need to investigate
There was a problem hiding this comment.
Let's see what CI and the convo here say: https://github.com/canton-network/splice/pull/4968/changes#r3701790278
| override val automation: AutomationConfig = AutomationConfig(), | ||
| mediatorVerdictIngestion: MediatorVerdictIngestionConfig = MediatorVerdictIngestionConfig(), | ||
| enableAppActivityRecordAndTrafficIngestion: Boolean = true, | ||
| serveAppActivityRecordsAndTraffic: Boolean = true, |
There was a problem hiding this comment.
@dfordivam @meiersi-da should this serveAppActivityRecordsAndTraffic option be kept in place or removed as well so the data is always served?
There was a problem hiding this comment.
The serveAppActivityRecordsAndTraffic should also be removed.
There was a problem hiding this comment.
Thanks, removed it
mrdziuban
changed the title
enableAppActivityRecordAndTrafficIngestion config optionenableAppActivityRecordAndTrafficIngestion and serveAppActivityRecordsAndTraffic config options
8ce5059 to
81a5740
Compare
…veAppActivityRecordsAndTraffic` config options. Fixes canton-network#6594 This removes the `enableAppActivityRecordAndTrafficIngestion` and `serveAppActivityRecordsAndTraffic` config options and the optionality proliferation that they resulted in. Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
81a5740 to
7ed9e82
Compare
|
@mrdziuban : note that I'm currently OoO. @rautenrieth-da will support @dfordivam to land your PR. |
7 participants
Fixes #6594
Changes are best viewed with whitespace ignored: https://github.com/canton-network/splice/pull/6643/changes?w=1
This removes the
enableAppActivityRecordAndTrafficIngestionandserveAppActivityRecordsAndTrafficconfig options and the optionality proliferation that they resulted in.Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines