[ci] Ignore INTERNAL from GetConnectedSynchronizers mid-reconnect - #6639
Open
ray-roestenburg-da wants to merge 1 commit into
Open
[ci] Ignore INTERNAL from GetConnectedSynchronizers mid-reconnect#6639ray-roestenburg-da wants to merge 1 commit into
ray-roestenburg-da wants to merge 1 commit into
Conversation
Canton fails the whole call when one synchronizer has no topology client during the remove/add window in SynchronizerRegistryHelpers. Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canton fails the whole call when one synchronizer has no topology client during the remove/add window in SynchronizerRegistryHelpers. See https://github.com/DACH-NY/cn-test-failures/issues/9445
(this is just the ignore, I'll try a fix in canton for the actual issue)
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines