Skip to content

Fix generated PR author policy #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielporterda wants to merge 1 commit into
base: main
Choose a base branch
from
+33 −3
Open

Fix generated PR author policy #1234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/validate_generated_pr_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@


REPO_ROOT = Path(__file__).resolve().parents[1]
EXPECTED_AUTHOR = "app/github-actions"
EXPECTED_AUTHOR = "app/cf-docs-generated-docs-merger"


@dataclass(frozen=True)
Expand Down
34 changes: 32 additions & 2 deletions tests/test_update_generated_reference_prs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,7 @@ def test_generated_pr_policy_accepts_configured_generated_paths() -> None:
head_sha="abc123",
),
pr_metadata={
"author": {"login": "app/github-actions"},
"author": {"login": "app/cf-docs-generated-docs-merger"},
"state": "OPEN",
"isDraft": False,
"baseRefName": "main",
Expand Down Expand Up @@ -1115,8 +1115,38 @@ def test_generated_pr_policy_rejects_unexpected_author_and_paths() -> None:
},
)

assert "expected PR author 'app/github-actions', found 'danielporterda'" in errors
assert "expected PR author 'app/cf-docs-generated-docs-merger', found 'danielporterda'" in errors
assert (
"changed files outside configured generated paths: .github/workflows/update-version-dashboard.yml"
in errors
)


def test_generated_pr_policy_rejects_legacy_github_actions_author() -> None:
policy = load_policy_module()

errors = policy.validate_policy(
policy_input=policy.PolicyInput(
pr_number="932",
repository="canton-network/cf-docs",
base_branch="main",
head_branch="version-dashboard/update",
head_sha="abc123",
),
pr_metadata={
"author": {"login": "app/github-actions"},
"state": "OPEN",
"isDraft": False,
"baseRefName": "main",
"headRefName": "version-dashboard/update",
"headRefOid": "abc123",
},
changed_files=("config/repo-version-config.json",),
branch_paths={
"version-dashboard/update": ("config/repo-version-config.json",),
},
)

assert errors == [
"expected PR author 'app/cf-docs-generated-docs-merger', found 'app/github-actions'"
]