Repository navigation
Use scaleset name as runner name prefix - #430
Merged
Merged
Conversation
weiiwang01
requested review from
cbartz,
florentianayuwono,
javierdelapuente,
yanksyoon and
yhaliaw
as code owners
October 15, 2026 18:29
yanksyoon
reviewed
Oct 16, 2026
yanksyoon
approved these changes
Oct 16, 2026
yanksyoon
left a comment
Member
There was a problem hiding this comment.
I'm thinking this should be a config option on the garm-configurator side, but i'll approve first since i'm okay with this approach. Thanks weii
cbartz
reviewed
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Use scaleset name as runner name prefix.
Why we need it
Currently, we are using the default runner name prefix, which is
garm-. This causes all runners to be named likegarm-aafdajfgle, which makes it really difficult to diagnose where this runner comes from when there's a problem. Fix this problem by using the scaleset name as the runner name prefix.Checklist
CONTRIBUTING.mdhas been updated upon changes to the contribution/development process (e.g. changes to the way tests are run)docs/changelog.mdwith user-relevant changes(e.g., in
.github/workflows/integration_tests.yaml, ensure themoduleslist is correct)terraform fmtpasses andtflintreports no errorsAGENTS.md.copilot-collections.yamlor.github/instructions/: I re-checked whether theAGENTS.md"12-factor divergences" guidance still matches the upstream copilot-collections guidance