Skip to content

Use scaleset name as runner name prefix - #430

Merged
weiiwang01 merged 1 commit into
mainfrom
runner-name
Oct 16, 2026
Merged

weiiwang01 merged 1 commit into
mainfrom
runner-name

Conversation

@weiiwang01

Copy link
Copy Markdown
Collaborator

What this PR does

Use scaleset name as runner name prefix.

Why we need it

Currently, we are using the default runner name prefix, which is garm-. This causes all runners to be named like garm-aafdajfgle, which makes it really difficult to diagnose where this runner comes from when there's a problem. Fix this problem by using the scaleset name as the runner name prefix.

Checklist

  • Changes comply with the project's coding standards and guidelines (see CONTRIBUTING.md and STYLE.md)
  • CONTRIBUTING.md has been updated upon changes to the contribution/development process (e.g. changes to the way tests are run)
  • Technical author has been assigned to review the PR in case of documentation changes (usually *.md files)
  • I updated docs/changelog.md with user-relevant changes
  • I used AI to assist with preparing this PR
  • I added or updated tests as needed (unit and integration)
  • If integration test modules are used: I updated the workflow configuration
    (e.g., in .github/workflows/integration_tests.yaml, ensure the modules list is correct)
  • If this PR involves a Grafana dashboard: I added a screenshot of the dashboard
  • If this PR involves Terraform: terraform fmt passes and tflint reports no errors
  • If this PR involves Rockcraft: I updated the version
  • If this PR adds/removes a charm, or changes a charm's base class, conventions, tooling, or repo structure: I updated the relevant AGENTS.md
  • If this PR changes .copilot-collections.yaml or .github/instructions/: I re-checked whether the AGENTS.md "12-factor divergences" guidance still matches the upstream copilot-collections guidance

Comment thread charms/garm/src/scaleset_reconciler.py

@yanksyoon yanksyoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking this should be a config option on the garm-configurator side, but i'll approve first since i'm okay with this approach. Thanks weii

Comment thread docs/changelog.md
@weiiwang01
weiiwang01 merged commit 10e5c98 into main Oct 16, 2026
63 checks passed
@weiiwang01
weiiwang01 deleted the runner-name branch October 16, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants