Repository navigation
Conversation
Scan the published charms and their OCI resources with Canonical secscan via sbomber after publish and weekly (SEC0025, ISD-6336).
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The gate supplies the secscan token incorrectly and lacks automated coverage for key enforcement paths.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Adds Canonical Secscan vulnerability scanning for charms and OCI resources, with CI gating and triage documentation.
Changes:
- Adds scheduled, manual, pull-request, and post-publish scanning.
- Defines scan artifacts, exclusions, and SSDLC metadata.
- Adds CVE gate logic and
SECURITY.mdguidance.
| File | Description |
|---|---|
SECURITY.md |
Documents vulnerability scanning and triage. |
.github/workflows/secscan.yaml |
Defines the Secscan workflow. |
.github/workflows/publish_charms.yml |
Invokes scanning after publishing. |
.github/secscan-exclusions/github-runner-webhook-gateway.txt |
Exclusions for the webhook gateway charm. |
.github/secscan-exclusions/github-runner-webhook-gateway-app-image.txt |
Exclusions for the webhook gateway image. |
.github/secscan-exclusions/github-runner-planner.txt |
Exclusions for the planner charm. |
.github/secscan-exclusions/github-runner-planner-app-image.txt |
Exclusions for the planner image. |
.github/secscan-exclusions/garm.txt |
Exclusions for the Garm charm. |
.github/secscan-exclusions/garm-configurator.txt |
Exclusions for the configurator charm. |
.github/secscan-exclusions/garm-app-image.txt |
Exclusions for the Garm image. |
.github/scripts/secscan_gate.py |
Gates results on unexcluded vulnerabilities. |
.github/sbomber-manifest.yaml |
Defines the seven scanned artifacts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What this PR does
Adds a
Secscanworkflow that scans the four charms (garm,garm-configurator,github-runner-planner,github-runner-webhook-gateway) and threeapp-imageOCI resources onlatest/edgewith Canonical secscan via sbomber. It runs after each publish to edge, weekly, on demand, and on PRs touching the scan files (same-repo only). A gate script fails the job on unexcluded CVEs; per-artifact exclusion files live in.github/secscan-exclusions/.SECURITY.mddocuments triage.Why we need it
SSDLC SEC0025 vulnerability scanning for the GitHub Runner product (ISD-6336).
Checklist
CONTRIBUTING.mdhas been updated upon changes to the contribution/development process (N/A: no change to dev process)docs/changelog.mdwith user-relevant changes (N/A: CI only)tox -e secscan-gate-unit; the workflow itself is exercised by this PR's run).copilot-collections.yamlor.github/instructions/: N/ATest plan
actionlint and zizmor pass (apart from the custom runner label, unknown to actionlint); gate script covered by
tox -e secscan-gate-unit(fakesecscan-client). Real run is this PR's Secscan check.Review focus
The
zizmor: ignore[self-repository]on the reusable-workflow call inpublish_charms.yml; the SSDLC cycle26.10in the manifest.AI-generated message.