Skip to content

feat: add terraform module for webhook gateway - #13

Merged
florentianayuwono merged 38 commits into
mainfrom
feat/webhook-terraform-ISD-4341
Nov 7, 2025
Merged

florentianayuwono merged 38 commits into
mainfrom
feat/webhook-terraform-ISD-4341

Conversation

@florentianayuwono

Copy link
Copy Markdown
Collaborator

Overview

Add terraform module for webhook gateway charm.

Rationale

To manage charm deployment and testing.

Checklist

  • The PR is tagged with appropriate label (urgent, trivial, senior-review-required, documentation).

@yanksyoon yanksyoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for majority of the definitions, thanks for this!

Comment thread .github/workflows/test_terraform_webhook_module.yaml Outdated
Comment thread .github/workflows/test_terraform_webhook_module.yaml
Comment thread .github/workflows/test_terraform_webhook_module.yaml Outdated
Comment thread webhook-gateway/charm/terraform/tests/.tflint.hcl Outdated
Comment thread webhook-gateway/charm/terraform/README.md Outdated
Comment thread webhook-gateway/charm/terraform/README.md Outdated
Comment thread webhook-gateway/charm/terraform/README.md Outdated
Comment thread webhook-gateway/charm/terraform/variables.tf
Comment thread webhook-gateway/charm/terraform/versions.tf Outdated
Comment thread .github/workflows/test_terraform_webhook_file.yaml Outdated
Comment thread .github/workflows/lint_terraform_webhook.yaml
Comment thread webhook-gateway/charm/terraform/tests/main.tftest.hcl
Comment thread webhook-gateway/charm/terraform/variables.tf Outdated
@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Unused entries in .trivyignore

Image: ghcr.io/canonical/webhook-gateway:7108af661eb83f1c6e64d6336cd3fec11d54a029-_0.1_amd64

The following CVEs are in .trivyignore but not ignored by Trivy anymore:

Comment thread webhook-gateway/charm/terraform/tests/main.tf Outdated
@github-actions

github-actions Bot commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Unused entries in .trivyignore

Image: ghcr.io/canonical/webhook-gateway:ff7365a0c44078e7d78ab5be68a63fe752135bd4-_0.1_amd64

The following CVEs are in .trivyignore but not ignored by Trivy anymore:

@yanksyoon yanksyoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-actions

github-actions Bot commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

Unused entries in .trivyignore

Image: ghcr.io/canonical/webhook-gateway:42dff747dc49df0fdf2c7e732f28d2e9f55baa69-_0.1_amd64

The following CVEs are in .trivyignore but not ignored by Trivy anymore:

@florentianayuwono
florentianayuwono merged commit dea52de into main Nov 7, 2025
12 checks passed
@florentianayuwono
florentianayuwono deleted the feat/webhook-terraform-ISD-4341 branch November 7, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants