Repository navigation
Conversation
Add log=False to all juju.deploy(), juju.config() and juju.exec() calls in integration tests to disable jubilant logging for security reasons. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
seb4stien
marked this pull request as ready for review
April 16, 2026 10:36
seb4stien
requested review from
cbartz,
florentianayuwono,
javierdelapuente,
weiiwang01,
yanksyoon and
yhaliaw
as code owners
April 16, 2026 10:37
javierdelapuente
approved these changes
Apr 16, 2026
florentianayuwono
approved these changes
Apr 16, 2026
weiiwang01
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable jubilant logging for all
juju.deploy(),juju.config()andjuju.exec()calls in integration tests by addinglog=False.Changes
tests/integration/test_charm_fork_path_change.pytests/integration/test_charm_runner.pytests/integration/helpers/common.pytests/integration/helpers/openstack.pytests/integration/test_prometheus_metrics.pytests/integration/conftest.py