Skip to content

fix(secret): use refresh=True to always use latest secret revision - #779

Merged
cbartz merged 2 commits into
mainfrom
fix/refresh-true-secrets-ISD-5330
Apr 14, 2026
Merged

cbartz merged 2 commits into
mainfrom
fix/refresh-true-secrets-ISD-5330

Conversation

@cbartz

@cbartz cbartz commented Apr 13, 2026 •

Copy link
Copy Markdown
Collaborator

Overview

Use refresh=True in get_content secret calls

Rationale

otherwise a secret update will not be considered

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The application version number is updated in github-runner-manager/pyproject.toml.

@cbartz
cbartz enabled auto-merge (squash) April 13, 2026 20:34
@cbartz

cbartz commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator Author

all tests passing except https://github.com/canonical/github-runner-operator/actions/runs/24365631114/job/71334209843?pr=779 , which is unlikely failing to PR change (rather flakiness), and the 24.04 version did pass. will force merge

@cbartz
cbartz disabled auto-merge April 14, 2026 19:56
@cbartz
cbartz merged commit 92eadf3 into main Apr 14, 2026
426 of 490 checks passed
@cbartz
cbartz deleted the fix/refresh-true-secrets-ISD-5330 branch April 14, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants