Repository navigation
fix(secret): use refresh=True to always use latest secret revision - #779
Merged
Merged
Conversation
cbartz
requested review from
florentianayuwono,
javierdelapuente,
weiiwang01,
yanksyoon and
yhaliaw
as code owners
April 13, 2026 13:31
florentianayuwono
approved these changes
Apr 13, 2026
yanksyoon
approved these changes
Apr 13, 2026
cbartz
enabled auto-merge (squash)
April 13, 2026 20:34
yhaliaw
approved these changes
Apr 14, 2026
Collaborator
Author
|
all tests passing except https://github.com/canonical/github-runner-operator/actions/runs/24365631114/job/71334209843?pr=779 , which is unlikely failing to PR change (rather flakiness), and the 24.04 version did pass. will force merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Use refresh=True in get_content secret calls
Rationale
otherwise a secret update will not be considered
Checklist
urgent,trivial,complex).github-runner-manager/pyproject.toml.