Skip to content

refactor: cleanup test environment variables - #655

Merged
yanksyoon merged 55 commits into
mainfrom
chore/cleanup-tests
Nov 26, 2025
Merged

yanksyoon merged 55 commits into
mainfrom
chore/cleanup-tests

Conversation

@yanksyoon

Copy link
Copy Markdown
Member

Applicable spec:

IMPORTANT

The testing secrets and environment variable mapping updates may break existing PRs when applied. Please merge this branch to fix the issues.

Overview

  • Use OS_ prefixed environment variables in test to match official OpenStack environment variables
  • Remove unused arm64 testing environment variables
  • Remove -amd64 suffix for parsers
  • Remove unused integration-token-alt fixture

Rationale

Test maintenance.

Juju Events Changes

Module Changes

Library Changes

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The application version number is updated in github-runner-manager/pyproject.toml.

Maintenance PR, no charm changes done.

Comment thread pyproject.toml Outdated

@cbartz cbartz left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. One (not blocking) comment.

Comment thread tests/conftest.py
@yanksyoon
yanksyoon requested a review from cbartz November 21, 2025 06:53
@yanksyoon
yanksyoon merged commit f7b1c3a into main Nov 26, 2025
89 of 94 checks passed
@yanksyoon
yanksyoon deleted the chore/cleanup-tests branch November 26, 2025 23:41
@cbartz cbartz mentioned this pull request Dec 1, 2025
6 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants