Skip to content

feat: add prometheus based grafana dashboard - #645

Merged
cbartz merged 19 commits into
mainfrom
feat/add-prometheus-based-dashboard
Nov 14, 2025
Merged

cbartz merged 19 commits into
mainfrom
feat/add-prometheus-based-dashboard

Conversation

@yanksyoon

@yanksyoon yanksyoon commented Oct 14, 2025 •

Copy link
Copy Markdown
Member

Overview

  • Adds a Grafana dashboard using Prometheus DS as source
image image image image

Rationale

  • Loki queries can be heavy, prometheus is preferred. However, there are drawbacks with Prometheus dashboards that need to be resolved, this PR introduces the initial version only.

Juju Events Changes

Module Changes

Library Changes

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The application version number is updated in github-runner-manager/pyproject.toml.

Addition of Grafana dashboard template, no logical changes made.
Documentation on charmhub will be added once dashboard is stabilised in production (after feedback cycles).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Prometheus-based Grafana dashboard for monitoring GitHub runner metrics. The change addresses performance concerns with Loki queries by providing an alternative dashboard that uses Prometheus as the data source.

Key Changes:

  • Added a new Grafana dashboard configuration file metrics_prometheus.json with panels for monitoring runner durations, counts, and totals
  • Updated the changelog to document this new feature

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/grafana_dashboards/metrics_prometheus.json New Prometheus-based dashboard with visualizations for runner queue durations, idle times, reconciliation metrics, VM operations, and runner counts
docs/changelog.md Added changelog entry documenting the new Prometheus dashboard feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/changelog.md Outdated
Comment thread src/grafana_dashboards/metrics_prometheus.json Outdated
Comment thread src/grafana_dashboards/metrics_prometheus.json Outdated
Comment thread src/grafana_dashboards/metrics_prometheus.json Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

@cbartz I've opened a new pull request, #651, to work on those changes. Once the pull request is ready, I'll request review from you.

@cbartz
cbartz requested a review from Copilot November 12, 2025 09:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread charmcraft.yaml
@cbartz

cbartz commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator

I've continued working on this PR since yesterday.

@cbartz
cbartz enabled auto-merge (squash) November 13, 2025 12:27
@cbartz
cbartz disabled auto-merge November 13, 2025 12:27
@cbartz
cbartz merged commit ef1fa06 into main Nov 14, 2025
84 of 105 checks passed
@cbartz
cbartz deleted the feat/add-prometheus-based-dashboard branch November 14, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants