Repository navigation
use multithreading instead of multiprocessing for spawning runners - #642
Merged
Merged
Conversation
cbartz
requested review from
javierdelapuente,
yanksyoon and
yhaliaw
as code owners
October 1, 2025 10:44
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR switches from multiprocessing to multithreading for spawning runners to reduce memory usage. The change anticipates future scaling needs where the charm may spawn many more runners across different OpenStack flavors and images.
- Replaced multiprocessing.Pool with multiprocessing.pool.ThreadPool
- Updated version number from 0.6.2 to 0.6.3
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| github-runner-manager/src/github_runner_manager/manager/runner_manager.py | Switched from Process Pool to Thread Pool for runner spawning |
| github-runner-manager/pyproject.toml | Bumped version number to reflect the change |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
javierdelapuente
approved these changes
Oct 1, 2025
yanksyoon
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
Use multithreading instead of multiprocessing
Rationale
multiprocessing is more costly in terms of memory. The charm might spawn way more runners than currently in the future once it is able to spawn runners for different openstack flavors,images, etc. In order to support this usecase, we remove the multiprocessing part.
Checklist
urgent,trivial,complex).github-runner-manager/pyproject.toml.No direct user impact (except fewer resource usage).