Repository navigation
fix: Remove -v in socat as in can incur in performance issues - #641
Merged
Merged
Conversation
javierdelapuente
requested review from
cbartz,
yanksyoon and
yhaliaw
as code owners
October 1, 2025 05:53
cbartz
approved these changes
Oct 1, 2025
cbartz
enabled auto-merge (squash)
October 8, 2025 08:45
yhaliaw
approved these changes
Nov 7, 2025
yanksyoon
approved these changes
Dec 1, 2025
Member
|
The workflow is failing due to jubilant model name not valid error: https://github.com/canonical/github-runner-operator/actions/runs/19851008044/job/56893532143?pr=641#step:25:195 |
Member
|
A passing test: A failing test: Looks like microk8s controller name is prepended twice - not quite sure why since there weren't any changes to this test. |
cbartz
added a commit
that referenced
this pull request
Dec 5, 2025
Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
cbartz
added a commit
that referenced
this pull request
Dec 13, 2025
* Initial plan * Update Crashed runner alert to reduce false positives - Change sum_over_time window from [1h] to [10m] - Increase threshold from > 0 to > 2 - Increase for duration from 0s to 15m This ensures we only alert if there are at least 3 crashes in a 10-minute window, and this state persists for 15 minutes. Co-authored-by: cbartz <4182921+cbartz@users.noreply.github.com> * ci: apply dockerhub mirror e2e (#661) * ci: microk8s use dockerhub mirror * ci: conditionally apply mirror if set * ci: use dockerhub mirror for microk8s in setup (#662) * ci: use dockerhub mirror for microk8s in setup * restart microk8s * chore(deps): update all non-major dependencies (#627) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: Add missing timeouts to GitHub, OpenStack, and repo policy compliance API calls (#659) * Initial plan * Add timeouts to GitHub, OpenStack, and repo policy compliance API calls - Added timeout parameter to missing GitHub API calls (list_self_hosted_runners_for_repo, list_self_hosted_runners_for_org) - Replaced hardcoded timeout value (60) with TIMEOUT_IN_SECS constant in list_jobs_for_workflow_run - Added OPENSTACK_API_TIMEOUT constant (5 minutes) to openstack_cloud/constants.py - Added timeout to OpenStack session.get call in _determine_max_compute_api_version_by_cloud - Added REPO_POLICY_COMPLIANCE_TIMEOUT constant (5 minutes) to repo_policy_compliance_client.py - Added timeout to repo policy compliance service API call All timeouts are configured as constants at the top of files for easy maintenance as requested. Co-authored-by: cbartz <4182921+cbartz@users.noreply.github.com> * Fix test mock to support timeout parameter in OpenStack session.get Updated FakeOpenstackCloud.session to return self instead of dict, and added get() method that accepts timeout parameter. This allows the timeout parameter to be properly passed through in tests. Co-authored-by: cbartz <4182921+cbartz@users.noreply.github.com> * Apply black formatting to fake_runner_managers.py Co-authored-by: cbartz <4182921+cbartz@users.noreply.github.com> * Increase GitHub API timeout from 60 seconds to 5 minutes Changed TIMEOUT_IN_SECS from 60 to 300 (5 minutes) to be consistent with OpenStack and repo policy compliance timeouts, and to address the problem statement suggestion of using 5-minute timeouts for API calls. Co-authored-by: cbartz <4182921+cbartz@users.noreply.github.com> * Improve test mock implementation for consistency - Store session response mock as instance variable for consistent behavior - Rename 'endpoint' parameter to 'url' for clarity - Address code review feedback Co-authored-by: cbartz <4182921+cbartz@users.noreply.github.com> * ci: apply dockerhub mirror e2e (#661) * ci: microk8s use dockerhub mirror * ci: conditionally apply mirror if set * ci: use dockerhub mirror for microk8s in setup (#662) * ci: use dockerhub mirror for microk8s in setup * restart microk8s * chore(deps): update all non-major dependencies (#627) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update changelog --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: cbartz <4182921+cbartz@users.noreply.github.com> Co-authored-by: Yanks Yoon <37652070+yanksyoon@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com> * test: fix jubilant controller prefix issue (#666) * test: fix jubilant controller prefix issue * test: update latest jubilant native syntax * test: use model prefixed offer * test: remove str type casting * test: add controller name * test: try again, unintuitive lib API design * test: try again * fix: Remove -v in socat as in can incur in performance issues (#641) Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com> * feat: pre job fork check (#648) * ci: organize secrets (#667) * ci: use secrets from env var mapping * test: disable github integration tests (preserve code as framework) * ci: map secret values to env vars * test: unify testing interface * test: unify testing interface * chore(deps): update all non-major dependencies (#664) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: cbartz <4182921+cbartz@users.noreply.github.com> Co-authored-by: Yanks Yoon <37652070+yanksyoon@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com> Co-authored-by: javierdelapuente <javier.delapuente@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
-vin socat writes transferred data to stderr, and it has been reported that it can generate network performance issues.Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
urgent,trivial,complex).github-runner-manager/pyproject.toml.