Skip to content

Use CI runners for integration tests - #629

Merged
cbartz merged 36 commits into
mainfrom
ci-runners
Sep 30, 2025
Merged

cbartz merged 36 commits into
mainfrom
ci-runners

Conversation

@yhaliaw

@yhaliaw yhaliaw commented Sep 3, 2025 •

Copy link
Copy Markdown
Collaborator

Applicable spec:

Overview

  • Adoption to move the integration tests and end-to-test environment.
  • For test_debug_ssh.py charm integration test, remove race condition to improve pass rate by changing the order of:
    • tmate ssh server charm integration with GitHub runner charm
    • GitHub charm spawning runner

Rationale

The old test environment will be removed.

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The application version number is updated in github-runner-manager/pyproject.toml.

The application is not updated. So no change in changelog or version number.

@yhaliaw
yhaliaw marked this pull request as ready for review September 26, 2025 02:32
@cbartz
cbartz enabled auto-merge (squash) September 30, 2025 05:10
@cbartz
cbartz merged commit e1eb15b into main Sep 30, 2025
199 of 233 checks passed
@cbartz
cbartz deleted the ci-runners branch September 30, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants