Skip to content

chore: add buckets to histogram metrics - #628

Merged
yanksyoon merged 8 commits into
mainfrom
chore/histogram-metric-buckets
Sep 5, 2025
Merged

yanksyoon merged 8 commits into
mainfrom
chore/histogram-metric-buckets

Conversation

@yanksyoon

Copy link
Copy Markdown
Member

Applicable spec:

Overview

  • Adds buckets to histogram metrics

Rationale

  • For metrics values that are not sub-seconds, the default bucket sizes are too fine-grained, making most of the metrics end up in +inf bucket.

Juju Events Changes

Module Changes

Library Changes

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The application version number is updated in github-runner-manager/pyproject.toml.

No user facing changes, only metrics bucket sizes are updated.

@cbartz cbartz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just two minor comments.

Comment thread github-runner-manager/src/github_runner_manager/metrics/runner.py Outdated
Comment thread github-runner-manager/src/github_runner_manager/metrics/runner.py Outdated
@yanksyoon
yanksyoon requested a review from cbartz September 2, 2025 05:23
Comment thread github-runner-manager/src/github_runner_manager/metrics/runner.py
@github-actions

github-actions Bot commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

TICS Quality Gate

❌ Failed

The following errors have occurred during analysis:

❌ [ERROR 5333] Project database 'github-runner-operator' already is connected to a started TICSQServer process that has not registered a stop time. To avoid data corruption, analysis is aborted. Details of the other TICSQServer process: started at 2025-07-09 14:32:08.000 by user ubuntu.

.github/workflows/tics.yaml / TICS / TICS GitHub Action

@yanksyoon
yanksyoon merged commit 77d1ed4 into main Sep 5, 2025
55 of 59 checks passed
@yanksyoon
yanksyoon deleted the chore/histogram-metric-buckets branch September 5, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants