Skip to content

fix(ci): bump NuGet packages with patched advisories for frozen revisions (NU1902/NU1903) #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yanksyoon wants to merge 1 commit into from
Closed

fix(ci): bump NuGet packages with patched advisories for frozen revisions (NU1902/NU1903) #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,30 @@ jobs:
sed -i "s/${current_version}/8.0/" src/global.json
fi

# Frozen upstream revisions (release branches, and rebuild branches such as
# arm-tarball-fix-2.338.0) keep the NuGet package versions that upstream pinned when
# the revision was cut. Upstream turns audit advisories into build errors
# (src/Directory.Build.props: NuGetAudit, NuGetAuditMode=all,
# NuGetAuditLevel=moderate, TreatWarningsAsErrors), so as soon as an advisory for one
# of those pins reaches NuGet's vulnerability feed, `dotnet restore` fails with
# NU1902/NU1903 and the revision can no longer be built at all. That is what broke
# Runner CI run 38847871799. Move the affected pins to the versions upstream already
# patched for those advisories (actions/runner#4777). Pins that are not listed here
# still fail the build, so the audit keeps its signal.
- name: Bump NuGet packages with patched advisories
run: |
# CVE-2026-84008 (high, GHSA-846f-f764-76mx) and CVE-2026-70162 (moderate,
# GHSA-2fmv-rv2c-59x7) in System.Security.Cryptography.Pkcs affect 8.0.0-8.0.1,
# 9.0.0-9.0.20 and 10.0.0-10.0.12, patched in 8.0.2, 9.0.21 and 10.0.13.
# Each sed matches only an affected version, so the step is a no-op on revisions
# that already pin a patched version (current main pins 10.0.13).
sed -i -E 's#System\.Security\.Cryptography\.Pkcs" Version="8\.0\.[01]"#System.Security.Cryptography.Pkcs" Version="8.0.2"#' src/Sdk/Sdk.csproj
sed -i -E 's#System\.Security\.Cryptography\.Pkcs" Version="9\.0\.([0-9]|1[0-9]|20)"#System.Security.Cryptography.Pkcs" Version="9.0.21"#' src/Sdk/Sdk.csproj
sed -i -E 's#System\.Security\.Cryptography\.Pkcs" Version="10\.0\.([0-9]|1[0-2])"#System.Security.Cryptography.Pkcs" Version="10.0.13"#' src/Sdk/Sdk.csproj
# Upstream bumps Formats.Asn1 in lockstep with Pkcs.
sed -i -E 's#System\.Formats\.Asn1" Version="10\.0\.([0-9]|1[0-2])"#System.Formats.Asn1" Version="10.0.13"#' src/Sdk/Sdk.csproj
grep -n -E 'System\.(Security\.Cryptography\.Pkcs|Formats\.Asn1)" Version=' src/Sdk/Sdk.csproj || true

# Build runner layout
- name: Build & Layout Release
run: |
Expand Down
24 changes: 24 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,30 @@ jobs:
sed -i "s/${current_version}/8.0/" src/global.json
fi

# Frozen upstream revisions (release branches, and rebuild branches such as
# arm-tarball-fix-2.338.0) keep the NuGet package versions that upstream pinned when
# the revision was cut. Upstream turns audit advisories into build errors
# (src/Directory.Build.props: NuGetAudit, NuGetAuditMode=all,
# NuGetAuditLevel=moderate, TreatWarningsAsErrors), so as soon as an advisory for one
# of those pins reaches NuGet's vulnerability feed, `dotnet restore` fails with
# NU1902/NU1903 and the revision can no longer be built at all. That is what broke
# Runner CI run 38847871799. Move the affected pins to the versions upstream already
# patched for those advisories (actions/runner#4777). Pins that are not listed here
# still fail the build, so the audit keeps its signal.
- name: Bump NuGet packages with patched advisories
run: |
# CVE-2026-84008 (high, GHSA-846f-f764-76mx) and CVE-2026-70162 (moderate,
# GHSA-2fmv-rv2c-59x7) in System.Security.Cryptography.Pkcs affect 8.0.0-8.0.1,
# 9.0.0-9.0.20 and 10.0.0-10.0.12, patched in 8.0.2, 9.0.21 and 10.0.13.
# Each sed matches only an affected version, so the step is a no-op on revisions
# that already pin a patched version (current main pins 10.0.13).
sed -i -E 's#System\.Security\.Cryptography\.Pkcs" Version="8\.0\.[01]"#System.Security.Cryptography.Pkcs" Version="8.0.2"#' src/Sdk/Sdk.csproj
sed -i -E 's#System\.Security\.Cryptography\.Pkcs" Version="9\.0\.([0-9]|1[0-9]|20)"#System.Security.Cryptography.Pkcs" Version="9.0.21"#' src/Sdk/Sdk.csproj
sed -i -E 's#System\.Security\.Cryptography\.Pkcs" Version="10\.0\.([0-9]|1[0-2])"#System.Security.Cryptography.Pkcs" Version="10.0.13"#' src/Sdk/Sdk.csproj
# Upstream bumps Formats.Asn1 in lockstep with Pkcs.
sed -i -E 's#System\.Formats\.Asn1" Version="10\.0\.([0-9]|1[0-2])"#System.Formats.Asn1" Version="10.0.13"#' src/Sdk/Sdk.csproj
grep -n -E 'System\.(Security\.Cryptography\.Pkcs|Formats\.Asn1)" Version=' src/Sdk/Sdk.csproj || true

# Build runner layout
- name: Build & Layout Release
run: |
Expand Down
Loading