Repository navigation
fix(release): regenerate runner patches for v2.338.0 and restore failure issues - #240
Conversation
Upstream bumped the .NET 8 SDK pin in src/dev.sh and src/global.json, which conflicts with the arm patch's .NET 9 pin. Keep the .NET 9 pin and let the release workflow accept patches already regenerated for the latest tag, so merging them creates the release branch.
There was a problem hiding this comment.
🔵 Needs a closer look
The release-critical ARM patch changes its SDK baseline and has not yet passed an actual ARM build.
0 open findings
What changed in this PR
Restores the v2.338.0 release flow after ARM patch conflicts and missing failure notifications.
Changes:
- Regenerates architecture patches against v2.338.0.
- Reuses validated, manually regenerated patches.
- Recreates the
ci-failurelabel before opening failure issues.
| File | Description |
|---|---|
patches/runner-sdk8-arm.patch |
Rebases ARM changes while retaining .NET 9. |
patches/runner-sdk8-ppc64le.patch |
Rebases ppc64le changes onto v2.338.0. |
patches/runner-sdk8-s390x.patch |
Rebases s390x changes onto v2.338.0. |
.github/workflows/patch_update_release.yml |
Accepts validated pre-regenerated patches. |
.github/workflows/create-issue-on-failure.yaml |
Ensures the failure label exists. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Re: review: verified locally: upstream v2.338.0 + AI-generated message. |
Fixes #237
Summary
src/dev.shandsrc/global.json(8.0.424 → 8.0.425), while the arm patch pins .NET 9 (9.0.318). I regenerated all threerunner-sdk8-*.patchfiles for v2.338.0. For arm, the conflict resolution keeps the .NET 9 pin. ppc64le and s390x rebased without conflicts.patch_update_release.ymlnow accepts a patch whose last line already says# From upstream release: <LATEST_TAG>. It checks that the patch applies cleanly and uses it as-is instead of rebasing. Merging manually regenerated patches then bumpslast_processed_tag.txtand createsreleases/<tag>as usual. Before this change, the run either failed again or skipped creating the release.ci-failurelabel had been deleted, sogh issue createfailed withcould not add label: 'ci-failure' not found. The workflow now recreates the label before opening the issue.Testing
git apply --checkagainst v2.338.0.AI-generated message.