Skip to content

fix(release): regenerate runner patches for v2.338.0 and restore failure issues - #240

Merged
cbartz merged 2 commits into
mainfrom
fix/release-2.338-patch-and-failure-issue
Oct 14, 2026
Merged

cbartz merged 2 commits into
mainfrom
fix/release-2.338-patch-and-failure-issue

Conversation

@cbartz

@cbartz cbartz commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

Fixes #237

Summary

  • Release 2.338 failed because the arm patch conflicts with v2.338.0: upstream bumped the .NET 8 SDK pin in src/dev.sh and src/global.json (8.0.424 → 8.0.425), while the arm patch pins .NET 9 (9.0.318). I regenerated all three runner-sdk8-*.patch files for v2.338.0. For arm, the conflict resolution keeps the .NET 9 pin. ppc64le and s390x rebased without conflicts.
  • Release workflow: patch_update_release.yml now accepts a patch whose last line already says # From upstream release: <LATEST_TAG>. It checks that the patch applies cleanly and uses it as-is instead of rebasing. Merging manually regenerated patches then bumps last_processed_tag.txt and creates releases/<tag> as usual. Before this change, the run either failed again or skipped creating the release.
  • No failure issue was opened because the ci-failure label had been deleted, so gh issue create failed with could not add label: 'ci-failure' not found. The workflow now recreates the label before opening the issue.

Testing

  • All regenerated patches pass git apply --check against v2.338.0.
  • I ran the edited "Process architectures" step locally against upstream in three setups. With the regenerated patches all arches succeed. With main's current patches it still fails on arm, as before. With only arm regenerated, all succeed.
  • Not tested: an actual arm build of 2.338.0 (CI will be the first). The label fix can't be checked until a monitored workflow fails.

AI-generated message.

Upstream bumped the .NET 8 SDK pin in src/dev.sh and src/global.json, which
conflicts with the arm patch's .NET 9 pin. Keep the .NET 9 pin and let the
release workflow accept patches already regenerated for the latest tag, so
merging them creates the release branch.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The release-critical ARM patch changes its SDK baseline and has not yet passed an actual ARM build.

0 open findings

What changed in this PR

Restores the v2.338.0 release flow after ARM patch conflicts and missing failure notifications.

Changes:

  • Regenerates architecture patches against v2.338.0.
  • Reuses validated, manually regenerated patches.
  • Recreates the ci-failure label before opening failure issues.
File Description
patches/​runner-sdk8-arm.patch Rebases ARM changes while retaining .NET 9.
patches/​runner-sdk8-ppc64le.patch Rebases ppc64le changes onto v2.338.0.
patches/​runner-sdk8-s390x.patch Rebases s390x changes onto v2.338.0.
.github/​workflows/​patch_update_release.yml Accepts validated pre-regenerated patches.
.github/​workflows/​create-issue-on-failure.yaml Ensures the failure label exists.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@cbartz
cbartz marked this pull request as ready for review October 13, 2026 13:24
@cbartz

cbartz commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

Re: review: verified locally: upstream v2.338.0 + patches/runner-sdk8-arm.patch → ./dev.sh layout Release linux-arm builds cleanly (exit 0, no errors or warnings). The layout targets .NETCoreApp,Version=v9.0/linux-arm with an armhf Runner.Listener. Note that the PR's build (linux-arm) check exercises runner-main-sdk8-arm.patch, not this release patch, so this was the missing coverage. Runtime behaviour on armhf hardware is still only covered by the release run.

AI-generated message.

@cbartz
cbartz merged commit 317cb69 into main Oct 14, 2026
9 checks passed
@cbartz
cbartz deleted the fix/release-2.338-patch-and-failure-issue branch October 14, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release 2.338 creation failed

3 participants