Repository navigation
fix(tics): make the TICS workflow pass on the TIOBE runner - #228
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The scoped workflow change addresses the test failure without unresolved issues.
Review effort: Lite
Findings: None
What changed in this PR
Updates the TICS workflow to prevent self-hosted runner hooks from affecting L0 tests.
Changes:
- Unsets both job-hook environment variables before running tests.
- Preserves coverage collection and test execution.
| File | Description |
|---|---|
.github/workflows/tics.yaml |
Prevents runner hooks from affecting L0 tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cbartz
marked this pull request as draft
October 1, 2026 13:52
cbartz
changed the title
cbartz
marked this pull request as ready for review
October 2, 2026 05:48
yanksyoon
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes to the TICS workflow so it completes on the TIOBE self-hosted runner:
ACTIONS_RUNNER_HOOK_JOB_STARTEDandACTIONS_RUNNER_HOOK_JOB_COMPLETEDbefore running the L0 suite.src/Test/TestLogs,_downloads) before TICS runs.Why
pre-job.shhook variable leaks into the tests, andJobExtensionL0.JobExtensionBuildStepsListfails withExpected: 5, Actual: 6(run 36863652543).ERROR 5023, threshold 200) (run 36871940880).Testing
actionlintpasses.BackgroundStepsL0.CanceledBackgroundStepDoesNotAffectJobResult; the re-run passed.AI-generated message.