feat: Support using go tool directive for protoc deps#91
Open
adombeck wants to merge 1 commit into
Open
Conversation
Contributor
Author
adombeck
changed the title
adombeck
force-pushed
the
protoc-go-tool
branch
from
November 6, 2025 14:04
4c2e126 to
e86163c
Compare
adombeck
changed the title
didrocks
reviewed
Nov 6, 2025
didrocks
left a comment
didrocks
left a comment
Contributor
There was a problem hiding this comment.
This is indeed way better! Wouldn’t that potentially break some repos though that are depending on this? Should we just update them first?
Contributor
Author
|
For migration I see two options:
|
|
@adombeck can you resolve the conflicts and resubmit for review? |
* Use `go tool` to check if protoc should be installed. * Drop support for installing tools from `tools/*.go` files - the only reason we kept it after #89 was to avoid breaking protoc.
Contributor
Author
|
Resolved the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go toolto check if protoc should be installed.tools/*.gofiles - the only reason we kept it after feat(go/generate): Incorporate go tool support #89 was to avoid breaking protoc.