Repository navigation
hooks/010-fixup-permissions.chroot: set correct group and setgid on unix_chkpwd - #481
Merged
Merged
Conversation
Meulengracht
requested review from
bboozzoo and
valentindavid
and
a lite review from Copilot
October 21, 2026 16:06
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified.
No open issues 🎉
What changed in this PR
Updates unix_chkpwd ownership and permissions to use the shadow group with setgid, with matching verification coverage.
Changes:
- Sets ownership to
root:shadowand mode2755. - Adds permission verification coverage.
| File | Description |
|---|---|
hooks/010-fixup-permissions.chroot |
Applies corrected ownership and setgid permissions. |
hook-tests/060-verify-file-permissions.test |
Verifies the expected file metadata. |
Review effort: Lite
bboozzoo
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.