Repository navigation
snapcraft, hooks: generate changes from package data - #480
Merged
Merged
Conversation
bboozzoo
force-pushed
the
bboozzoo/get-changelogs
branch
from
October 21, 2026 10:11
96f8166 to
a9bd4c0
Compare
Signed-off-by: Maciek Borzecki <maciej.borzecki@canonical.com>
bboozzoo
force-pushed
the
bboozzoo/get-changelogs
branch
from
October 21, 2026 10:13
a9bd4c0 to
70f24ab
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Three critical findings remain unresolved and may cause builds to fail.
3 open issues
What changed in this PR
This PR updates core26 changelog generation using chisel package data and removes changelog archives from the final image.
Changes:
- Adds package changelog slices and stages package metadata.
- Generates
dpkg.yamlandChangeLogfrom a temporary sysroot. - Removes changelog archives during hooks.
| File | Summary | Final review findings |
|---|---|---|
tools/generate-changelog.py |
Updates the package changelog allowlist. | Critical (1 vote): kmod_bins and openssh-server_* lack chisel changelog slices or explicit fallback handling, causing non-Launchpad builds to fail. |
snapcraft.yaml |
Adds changelog slices and generation staging. | Critical (4 votes): Add the missing openssh-server_changelog slice. Critical (1 vote): Restrict nvidia-kernel-common-595_changelog to amd64/arm64. |
hooks/040-remove-slices.chroot |
Removes package changelog archives from the final image. | No final findings. |
Review effort: Lite
| pkg_allowed_list = [ | ||
| 'dpkg', # is removed during hook | ||
| 'openssl' # contains a symlink which is broken currently | ||
| 'openssl', # contains a symlink which is broken currently |
Contributor
Author
There was a problem hiding this comment.
neither kmod, nor openssh-server have their slices defined. The changelog.gz is owned by a different package (e.g. openssh-client) or has no associated package ownership at all (kmod)
bboozzoo
marked this pull request as ready for review
October 21, 2026 11:11
bboozzoo
commented
Oct 21, 2026
Comment on lines
+288
to
+290
| python3 "${CRAFT_PROJECT_DIR}/tools/wall2dpkg.py" \ | ||
| "${CRAFT_PART_INSTALL}/base/var/lib/chisel/manifest.wall" \ | ||
| /tmp/dpkg.yaml 2>/dev/null || true |
Comment on lines
+295
to
+299
| openssh-server |\ | ||
| kmod |\ | ||
| libatomic1 |\ | ||
| libgcc-s1 |\ | ||
| libncursesw6 |\ |
| libstdc++6 |\ | ||
| openssh-sftp-server |\ | ||
| p11-kit-modules |\ | ||
| sgml-base) |
Member
There was a problem hiding this comment.
There is a changelog.gz in sgml-base
bboozzoo
commented
Oct 21, 2026
| libstdc++6 |\ | ||
| openssh-sftp-server |\ | ||
| p11-kit-modules |\ | ||
| sgml-base) |
Contributor
Author
There was a problem hiding this comment.
drop once canonical/chisel-ubuntu-core#11 lands
Meulengracht
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: SNAPDENG-37858