feat(26.04): update sensible-utils and ucf#985
Open
lczyk wants to merge 27 commits into
Open
Conversation
|
Diff of dependencies: slices/dpkg.yaml@@ -1,8 +1 @@
-libbz2-1.0
-libc6
-liblzma5
-libmd0
-libselinux1
-libzstd1
-tar
-zlib1g
+slices/gettext-base.yaml@@ -1 +1 @@
-libc6
+slices/sensible-utils.yaml@@ -0,0 +1 @@
+slices/ucf.yaml@@ -1,5 +1 @@
-debconf
-debconf-2.0
-libtext-wrapi18n-perl
-procps
-sensible-utils
+ |
lczyk
changed the title
sensible-utilssensible-utils and ucf
Test CoverageAverage Total Coverage: 28.75% Arch: aarch64Coverage: 28.75%
|
Collaborator
Author
|
adding priority since its part of essential 26.04 work |
3 tasks
alesancor1
reviewed
Apr 22, 2026
alesancor1
left a comment
alesancor1
left a comment
Member
There was a problem hiding this comment.
Looks good overall, couple of comments/questions below:
Comment on lines
+42
to
+45
| # coreutils_md5sum: | ||
| coreutils_readlink: | ||
| coreutils_rm-utility: | ||
| # coreutils_seq: |
Member
There was a problem hiding this comment.
Why are md5sum and seq commented?
zhijie-yang
requested changes
Apr 22, 2026
| # gettext.sh can be sourced and provides eval_gettext and eval_ngettext | ||
| c='. /usr/bin/gettext.sh && eval_gettext "Hello World"' | ||
| chroot "$rootfs" sh -c "$c" | grep -q "Hello World" | ||
| c='. /usr/bin/gettext.sh && n=1 && eval_ngettext "one item" "many items" 1' |
Collaborator
There was a problem hiding this comment.
What is this n=1 for?
| /usr/bin/sensible-pager: | ||
| /usr/bin/sensible-terminal: | ||
|
|
||
| mime: |
Collaborator
There was a problem hiding this comment.
Why do we drop _mime? This is a regression without alternatives.
|
|
||
| ucfq: | ||
| hint: Query config file registry | ||
| essential: |
Collaborator
There was a problem hiding this comment.
Suggested change
| essential: | |
| essential: | |
| coreutils_md5sum: |
It's required by ucfq:
root@690f077c9c58:/work/26.04-amd64# grep -R 'md5sum' ucf
ucf/etc/ucf.conf:# md5sums for a file are looked for. Specifically, the historical
ucf/etc/ucf.conf:# md5sums are looked for in the subdirectory ${filename}.md5sum.d/
ucf/usr/bin/ucfq: if (-x "/usr/bin/md5sum") {
ucf/usr/bin/ucfq: open (my $newhash, "-|", "/usr/bin/md5sum $name") ||
ucf/usr/bin/ucfq: die "Could not run md5sum: $!";
ucf/usr/bin/ucfq: die "Could not find /usr/bin/md5sum .\n";
...
| coreutils_dirname: | ||
| coreutils_id-utility: | ||
| coreutils_mv-utility: | ||
| # coreutils_md5sum: |
Collaborator
There was a problem hiding this comment.
This is required by ucf:
ucf/usr/bin/ucf: md5sum "$orig_new_file" | sed "s|$orig_new_file|$dest_file|" >&2
ucf/usr/bin/ucf: md5sum "$orig_new_file" | sed "s|$orig_new_file|$dest_file|" >> \
ucf/usr/bin/ucf: echo " md5sum \"$orig_new_file\" | sed \"s|$orig_new_file|$dest_file|\"; "
ucf/usr/bin/ucf: md5sum "$orig_new_file" | sed "s|$orig_new_file|$dest_file|" > \
ucf/usr/bin/ucf: echo " md5sum \"$orig_new_file\" | sed \"s|$orig_new_file|$dest_file|\" >" \
...
| # coreutils_md5sum: | ||
| coreutils_readlink: | ||
| coreutils_rm-utility: | ||
| # coreutils_seq: |
Collaborator
There was a problem hiding this comment.
This is required
ucf/usr/bin/ucf: for i in $(/usr/bin/seq 6 -1 0); do
ucf/usr/bin/ucf: for i in $(/usr/bin/seq 6 -1 0); do
| coreutils_id-utility: | ||
| coreutils_mv-utility: | ||
| coreutils_readlink: | ||
| # coreutils_seq: |
Collaborator
There was a problem hiding this comment.
Suggested change
| # coreutils_seq: | |
| coreutils_seq: |
| coreutils_readlink: | ||
| # coreutils_seq: | ||
| dash_bins: | ||
| # dpkg_dpkg-divert: |
Collaborator
There was a problem hiding this comment.
This is required for ucfr:
root@690f077c9c58:/work/26.04-amd64# grep -R 'dpkg-divert' ucf
ucf/usr/bin/ucfr: divert_package=$(dpkg-divert --listpackage "$conf_file")
Collaborator
There was a problem hiding this comment.
I believe the tests need a re-work: The coverage of logics/branches in the script is way below sufficiency, if only the --help subcommand is tested.
3 tasks
lczyk
added
Blocked
lczyk
added
Priority
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
sensible-utilsto classify the content as scriptssensible-utilsucfto classify contents as scriptsucf. there are many bits missing from these slices which would be needed for a full test. this is still a massive improvement though.dpkgtests layout while preserving previous test casesupdate-alternativesand add tests for itgettext-baseand add tests for itRelated issues/PRs
sensible-utilsanducfslice renames #995Forward porting
n/a
Checklist