feat(24.04): add slices for ffmpeg and dependencies#930
Conversation
There was a problem hiding this comment.
will have more of a look tomorrow, but on first glance looks really good! ^_^
note; this PR will need forward ports to 25.10 and 26.04, but given that it's mostly libs it should be straightforward. from a cursory look, this is how it looks on noble (aka this PR):
Package: ffmpeg
Version: 7:6.1.1-3ubuntu5
Depends:
libavcodec60 (>= 7:6.1)
libavdevice60 (>= 7:6.0)
libavfilter9 (>= 7:6.0)
libavformat60 (>= 7:6.0)
libavutil58 (>= 7:6.0)
libc6 (>= 2.35)
libpostproc57 (>= 7:6.0)
libsdl2-2.0-0 (>= 2.0.12)
libswresample4 (>= 7:6.0)
libswscale7 (>= 7:6.0)
and this is it in resolute:
Package: ffmpeg
Version: 7:7.1.1-1ubuntu4.2
Depends:
libavcodec61 (>= 7:7.1)
libavdevice61 (>= 7:7.0)
libavfilter10 (>= 7:7.0)
libavformat61 (>= 7:7.0)
libavutil59 (>= 7:7.1)
libc6 (>= 2.35)
libplacebo349 (>= 7.349.0)
libpostproc58 (>= 7:7.0)
libsdl2-2.0-0 (>= 2.0.12)
libswresample5 (>= 7:7.0)
libswscale8 (>= 7:7.0)
so not miles off
Test CoverageAverage Total Coverage: 15.60% Arch: aarch64Coverage: 15.60%
|
…ter9 and libpocketsphinx3
…in ffmpeg integration tests
Using format: v3 instead of v2
lczyk
left a comment
There was a problem hiding this comment.
a pile of nitpicks + one minor test failure to still fix, but overall this is an incredibly solid PR! will wait with FP review until the changes from this PR. i'm guessing though it will only be a case of going through all the libs with ldd
Co-authored-by: Marcin Konowalczyk <marcin.konowalczyk@canonical.com>
Co-authored-by: Marcin Konowalczyk <marcin.konowalczyk@canonical.com>
Co-authored-by: Marcin Konowalczyk <marcin.konowalczyk@canonical.com>
Co-authored-by: Marcin Konowalczyk <marcin.konowalczyk@canonical.com>
Co-authored-by: Marcin Konowalczyk <marcin.konowalczyk@canonical.com>
|
Thanks! That spread failure is weird. Did proxy.golang.org have an outage? |
i guess 🤷♀️ i retriggered just the tests and its running fine now |
lczyk
left a comment
There was a problem hiding this comment.
thank you for all the great work! looks fantastic to me :)
will poke ppl in @canonical/rocks / @canonical/slice-reviewers-guild to have a look too, and will review the forward ports once the changes from this review are ported there too.
|
Updated both FPs to be in sync with this 24.04 PR |
|
Friendly bump on these PRs 😄 |
bump ack. sorry, 26.04 release is coming up and that's just jumping the priority queue left and right. 😓 |
Proposed changes
Create new SDFs for ffmpeg and needed dependencies
Related issues/PRs
Building on previous work by @HadrienPatte: #328 and #359
Forward porting
Checklist
Additional Context
We have been using
ffmpeg_binsinternally for awhile, now thatv3-essentialis available we can upstream these slices.The included sample video originates from https://samples.ffmpeg.org/4khdr/PE2_Leopard_1080.mkv