report: decode crash output to string in add_kernel_crash_info#620
Open
bdrung wants to merge 1 commit into
Open
report: decode crash output to string in add_kernel_crash_info#620bdrung wants to merge 1 commit into
bdrung wants to merge 1 commit into
Conversation
The functions `Report.crash_signature_addresses` and `Report._crash_signature_kernel_crash` expect the value for `Stacktrace` to be a string. So let `add_kernel_crash_info` set the value for `Stacktrace` as string by decoding the `crash` output to UTF-8. Bug: https://launchpad.net/bugs/2146806
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
=======================================
Coverage 84.54% 84.54%
=======================================
Files 104 104
Lines 21028 21028
Branches 3219 3219
=======================================
Hits 17779 17779
+ Misses 2809 2808 -1
- Partials 440 441 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions
Report.crash_signature_addressesandReport._crash_signature_kernel_crashexpect the value forStacktraceto be a string.So let
add_kernel_crash_infoset the value forStacktraceas string by decoding thecrashoutput to UTF-8.Bug: https://launchpad.net/bugs/2146806