Skip to content

GRUD_DEV-1250/group column permissions - #579

Merged
zingmane merged 3 commits into
masterfrom
GRUD_DEV-1250/group-column-permissions
Sep 18, 2026
Merged

zingmane merged 3 commits into
masterfrom
GRUD_DEV-1250/group-column-permissions

Conversation

@smnhgn

@smnhgn smnhgn commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

Submit a pull request

Related Ticket: GRUD_DEV-1250

Please make sure the following is true

  • I gave the PR a meaningful name
  • I checked that the correct target branch is selected
  • I rebased the branch on the target branch and it can be merged
  • I ran the linter and it did pass
  • I checked for unused code / dead code / debug code
  • I checked that variables/functions have meaningful names
  • I checked that the behaviour is as the documentation/task describes and I tested it
  • I updated the docs / specifications if possible
  • I could explain all that code when someone wakes me up at 3am
  • I checked that the code considers failures and not just the happy path
  • There are no new dependencies OR I listed them and explained them below
  • PR introduces no breaking changes OR I listed them and described them below
  • I added/updated tests for new/modified unit-testable functions/helpers
  • I ran the tests and they did pass

Other information/comments (e.g. reasons why points are not checked from above)

Important

Muss in Verbindung mit dem Backend-PR GRUD_DEV-1250/group column permissions getestet werden!

Reason for this PR

Bisher wurde die GroupCell immer als editierbar angezeigt.
Mit den Änderungen werden in der GroupCell nun die Permissions und sonstige Kriterien (UnionTable, archived etc.) berücksichtigt.
Bzgl. Permissions wird die GroupCell nur als editierbar gewertet, wenn mindestens eine der enthaltenen Spalten editierbar ist.

@smnhgn
smnhgn requested a review from hermann-p as a code owner September 11, 2026 12:39

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@smnhgn
smnhgn added this pull request to stack #580 September 14, 2026 08:57
@smnhgn
smnhgn force-pushed the GRUD_DEV-1250/group-column-permissions branch 2 times, most recently from 0d8798a to a703a76 Compare September 14, 2026 09:34
hermann-p
hermann-p previously approved these changes Sep 14, 2026

@hermann-p hermann-p left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, schaut gut aus mit den Permissions. Schön zentral gefixt und das Verhalten mit dem Öffnen aber beibehalten/wiederhergestellt - hier hatte ich meinen Kommentar zum PR wohl aus Versehen in den übergeordneten Branch geschrieben.

@smnhgn
smnhgn dismissed hermann-p’s stale review September 14, 2026 13:26

The merge-base changed after approval.

@smnhgn
smnhgn force-pushed the GRUD_DEV-1250/group-column-permissions branch from a703a76 to 1e50a1f Compare September 14, 2026 13:27
@smnhgn
smnhgn force-pushed the GRUD_DEV-1250/group-column-permissions branch from 1e50a1f to 4ad3ec0 Compare September 15, 2026 07:45
@zingmane
zingmane disabled the stack merge September 18, 2026 13:18
@zingmane
zingmane disabled the stack merge September 18, 2026 13:22
@zingmane
zingmane force-pushed the GRUD_DEV-1250/group-column-permissions branch from 4ad3ec0 to c9dd4a6 Compare September 18, 2026 13:23
Base automatically changed from GRUD_DEV-1247/refactor-group-display-value to master September 18, 2026 13:25
smnhgn and others added 3 commits September 18, 2026 15:25
A group column has no editCellValue of its own, so a group cell is editable
as soon as one of its members is.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@zingmane
zingmane force-pushed the GRUD_DEV-1250/group-column-permissions branch from c9dd4a6 to d2983d9 Compare September 18, 2026 13:25
@zingmane
zingmane merged commit 6cf7744 into master Sep 18, 2026
1 check passed
@zingmane
zingmane deleted the GRUD_DEV-1250/group-column-permissions branch September 18, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants