Skip to content

[18.0][REF] cloud_platform,monitoring_prometheus: server_environment should not be a required dependency#519

Merged
ivantodorovich merged 2 commits into
18.0from
18-remove-server-env-dep
May 20, 2026
Merged

[18.0][REF] cloud_platform,monitoring_prometheus: server_environment should not be a required dependency#519
ivantodorovich merged 2 commits into
18.0from
18-remove-server-env-dep

Conversation

@yankinmax
Copy link
Copy Markdown
Member

@yankinmax yankinmax commented Mar 30, 2026

PR is aimed to remove server_environment dependency from cloud_platform and monitoring_prometheus in the scope of this issue:

https://camptocamp.atlassian.net/browse/BSRD-887

@yankinmax yankinmax force-pushed the 18-remove-server-env-dep branch from 5fc29b2 to b0ef10f Compare March 30, 2026 14:01
@yankinmax
Copy link
Copy Markdown
Member Author

yankinmax commented Mar 30, 2026

Hello @ivantodorovich
I'm not a big expert in these modules.
Following the issue raised and the card description I've opened this PR.
Regarding the monitoring_statsd I wonder if we can split it. The way it's implemented required server_environment included, otherwise it doesn't make any sense to have it declared.
Other modules in the repo don't have direct/indirect dependency.

Can you pls take a look?

I think if these two will be validated for the server_environment removal we need to decide if we need to forward-port it to v16 and 17?

@yankinmax yankinmax force-pushed the 18-remove-server-env-dep branch from b0ef10f to a322353 Compare March 30, 2026 14:20
Copy link
Copy Markdown
Member

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cloud_platform, see my comment below. I believe we can drop the dependency altogether.

For monitoring_prometheus, I don't really understand the split. The extracted things don't really seem to depend on server environment. I think the server_environment dependency might have not been real there, and you can remove too

Comment thread cloud_platform/models/cloud_platform.py
@yankinmax yankinmax force-pushed the 18-remove-server-env-dep branch from a322353 to 14ecc4b Compare March 31, 2026 06:15
@yankinmax yankinmax changed the title [18.0][ADD] cloud_platform_environment: make server_environment an optional dependency [REF] cloud_platform,monitoring_prometheus: server_environment should not be a required dependency Mar 31, 2026
@yankinmax yankinmax changed the title [REF] cloud_platform,monitoring_prometheus: server_environment should not be a required dependency [18.0][REF] cloud_platform,monitoring_prometheus: server_environment should not be a required dependency Mar 31, 2026
Comment thread monitoring_prometheus/models/ir_http.py Outdated
@yankinmax yankinmax force-pushed the 18-remove-server-env-dep branch from 14ecc4b to e02e819 Compare March 31, 2026 15:08
@yankinmax yankinmax force-pushed the 18-remove-server-env-dep branch from e02e819 to 84392c1 Compare May 20, 2026 06:56
@ivantodorovich ivantodorovich merged commit 7585789 into 18.0 May 20, 2026
4 checks passed
@ivantodorovich ivantodorovich deleted the 18-remove-server-env-dep branch May 20, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants