fix: add DISABLE_SIGNIFICANCE_FILTER env var to bypass memory filtering#296
Merged
RyanNg1403 merged 1 commit intomainfrom Mar 16, 2026
Merged
fix: add DISABLE_SIGNIFICANCE_FILTER env var to bypass memory filtering#296RyanNg1403 merged 1 commit intomainfrom
RyanNg1403 merged 1 commit intomainfrom
Conversation
The isSignificantKnowledge() and isWorkspaceSignificantContent() functions use regex skipPatterns that silently reject legitimate content containing words like "email", "address", "phone", "login", "password". This causes memory extraction to return extracted: 0, skipped: 1 with no user-facing indication of why. Add DISABLE_SIGNIFICANCE_FILTER=true env var to bypass these filters. Default is false (no behavior change for existing users). Also fixes pre-existing prettier formatting in neo4j.ts. Fixes #263
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DISABLE_SIGNIFICANCE_FILTER=trueenv var to bypass theisSignificantKnowledge()andisWorkspaceSignificantContent()filtersfalse— no behavior change for existing usersProblem
The significance filter uses
skipPatternsthat match common technical terms:Content mentioning "email" (email services, SMTP), "address" (IP addresses, memory addresses), "login" (auth systems), etc. is silently discarded. The tool returns
extracted: 0, skipped: 1with no user-facing indication that the filter was the cause — identical to a dedup skip.Root cause analysis by @MafraAiDev in #263.
Usage
What this does NOT guarantee
Issue #263 has multiple reporters with different setups and potentially different root causes:
Test plan
pnpm run format:checkpassesDISABLE_DEFAULT_MEMORY,DISABLE_EMBEDDINGS, etc.false— zero behavior change unless explicitly opted inFixes #263