fix: skip env var case-sensitivity test on Windows#294
Merged
RyanNg1403 merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
Windows treats environment variable names as case-insensitive, so setting both test_var and TEST_VAR overwrites the same variable. Skip this test on Windows since the behavior is platform-dependent by design, not a code bug. Also removes leftover console.log debug line. Fixes #229 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pre-existing formatting issue unrelated to the test fix. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
it.skipIf(process.platform === 'win32')console.log(result)debug lineOn Windows,
process.env.test_varandprocess.env.TEST_VARrefer to the same variable (Windows env vars are case-insensitive by design). The test assumes case-sensitive env vars, which is only true on Unix/macOS. This is a platform limitation, not a code bug — skipping on Windows is the correct fix.Test plan
it.skipIfFixes #229
🤖 Generated with Claude Code