Skip to content

chore(fork): retain 0.15.2 basket carry on 0.16.0-beta.2 - #29

Merged
camerontaylor merged 233 commits into
customfrom
upgrade/basket-0.16.0-beta.2
Nov 12, 2026
Merged

camerontaylor merged 233 commits into
customfrom
upgrade/basket-0.16.0-beta.2

Conversation

@camerontaylor

Copy link
Copy Markdown
Owner

What this is

Retained fork carry (origin/upgrade/basket-0.15.2 at 531b041e) merged onto the
synced custom source for upstream v0.16.0-beta.2 (peeled source
23bae61535542a45ade7196a7b3c152705f16de3). This is the full retained
candidate branch for the 0.16 beta Desvio build: it keeps the TMAD-derived
basket carry per the owner clarification, and is not a wholesale removal.

Custom is included through the reviewed promotion merge c0c6ad9, which
contains 298af48b (PR #28, independent GLM PASS at that head).

Conflict resolution decisions

38 conflicted paths were resolved with explicit ownership decisions preserved
in basket-owner-decisions.md:

  • Strict invalid-ACP-model rejection kept in production validation and tests.
  • Finish/error attention is restamped on each later outcome while pending
    permission attention stays protected; custom's repeated-error path remains.
  • Chat find is ported onto upstream's combined history/live LegendList rows:
    sourceId aliases, disclosure-hold and bottom-anchor detach, one
    animation-frame jump delay, latest-index lookup, cancellation on new request
    or unmount. The new native-message-scroll module owns that behavior and has
    focused tests.
  • Package script discovery/search stays menu-local; restart actions remain
    screen-owned so a pending restart survives menu teardown.
  • History navigation stays in the beta keyboard pipeline (goHistory port)
    with fork Cmd/Ctrl+[] bindings; workspace-relative navigation moves to
    Cmd/Ctrl+Alt+[]. Browser Alt+[] is unchanged.
  • Custom production fixes preserved: correlated ACP usage exactly once,
    narrowed runtime canonical-model alias adoption, Claude graceful-close
    fixture alignment with upstream fix(claude): preserve restart recovery during graceful shutdown getpaseo/paseo#8686.

The independent PR #28 review also flagged a P3 test gap on the nonrestoring
refresh-alias cell. This PR adds that direct fixture: config keeps the
requested alias while the observed canonical name is unchanged and adopts
after a genuine observed change.

Merge-seam repairs

Beyond conflict resolution, the first full build exposed real union defects,
fixed here: stale checkout import after upstream moved commit-file reads behind
CheckoutDiffManager.readCommitFile; missing viewMatch in fork PR lookup;
app seams for draft tabs, plan handoff provider options, PR overlay
registration, compact tab switcher handlers; duplicate switcher render;
duplicate test imports/keys; and complexity/lint regressions from the union.

Gates at this head

  • Formatter, root lint, and root typecheck green on the private Ceres checkout.
  • Named server/plugin/protocol/client test suites run on the exact head;
    results attached in the rollout receipts.
  • Upstream source v0.16.0-beta.2; no publication or deployment from this PR.

colonelpanic8 and others added 30 commits September 27, 2026 21:18
Multiple profiles extending the same provider have been supported in
config.json for a while, but the only way to create one was editing the
file by hand. The daemon already accepted full profile writes over
set_daemon_config, so this is client surface only.

App: the provider row actions menu gains "Add account" for built-in
providers, opening a form for label, provider id, description, and
environment variables. The glossary reserves "profile" for HostProfile,
so the UI says account.

CLI: paseo provider add/rm, with client-side validation mirroring
ProviderOverridesSchema so errors name the offending flag instead of
arriving from the daemon. provider ls gains a SOURCE column.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The providers-section unit test mocks its heavy children, so importing
the real account sheet pulled in react-native-reanimated and failed the
suite at parse time. Stub the sheet the way the catalog list is already
stubbed, and cover the new menu item.

canAddProviderAccount required source === "builtin", but source is
optional on the wire, so daemons predating it hid the action entirely.
Reject only an explicit "custom": the daemon reports builtin ids as
"builtin" regardless of overrides, so no custom row can reach here.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Custom provider accounts now carry an optional baseProviderId on provider
snapshot entries. Model/provider pickers group each account immediately
after its base provider and reuse the base provider's icon, matching the
Settings providers list.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Renaming a provider account previously orphaned every chat that used it:
persisted agents kept the old provider id, dropped out of listings, and
failed to load. The config patch gains an optional renameProviders map;
the daemon repoints live agents and rewrites stored records (provider,
runtimeInfo.provider, persistence.provider) to the new id, then
rebroadcasts config so clients refresh. The capability is advertised as
the providerConfigRename feature; when a connected daemon lacks it, the
edit sheet warns that changing the ID will orphan existing chats.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Icon call sites that render straight from an agent's provider id (agent
list, schedules, panels, and the sidebar's per-workspace provider
glyphs) fell back to the generic bot icon for second accounts like
"claude-work", because the static icon lists can't know user-chosen
account ids. Register each snapshot entry's baseProviderId as an icon
alias wherever snapshot entries land on the client, and let
resolveProviderIconName consult those aliases before giving up, so
every getProviderIcon caller shows the real provider logo without
threading snapshot data through each call site.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Korean landed upstream after this branch forked.
An assembly merge reintroduced main's bare ProviderUsageService
construction after this branch's injected assignment, so the configured
instance was overwritten and no provider-account usage fetcher ever ran:
second accounts silently lost their usage rows. A clean merge shows no
conflict, so nothing surfaced until the daemon served usage.

Assert that the server keeps the instance it was handed; the test fails
the moment a duplicate assignment reappears.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
# Conflicts:
#	packages/server/src/server/plugins/usage-sources/index.test.ts
#	packages/server/src/server/plugins/usage-sources/index.ts
#	plugins/claude-usage-source/server/usage.ts
#	plugins/claude-usage-source/shared/input.ts
#	plugins/codex-usage-source/server/usage.ts
#	plugins/codex-usage-source/shared/input.ts
#	plugins/copilot-usage-source/server/usage.ts
#	plugins/copilot-usage-source/shared/input.ts
Keep account discovery on the keyed usage contract and narrow routed inputs for the Codex and Copilot plugins.
Preserve source file links, fork-first PR lookup, desktop quit confirmation, nested package scripts, comparison-base mutation and project PR CI facts. Extend upstream PR listing and keep upstream script status broadcasting.

Source-IP01: cabbc69
Source-IP02: 6373605
Source-IP03: 0d4161b
Source-IP04: 1967db5
Source-IP07: 06b79b7
Source-IP13: f3a66c4
# Conflicts:
#	packages/app/src/agent-stream/view.tsx
camerontaylor and others added 16 commits November 9, 2026 21:36
…uting

test(terminal): Isolate packaged zsh prompt startup directory
fix(terminal): Own managed zsh command completion
…ture

test(cli): Use current terminal worker protocol in upgrade fixture
Merge origin/upgrade/basket-0.15.2 (531b041) into the assembled 0.16 beta
source, preserving TMAD-derived carry per the owner clarification.

Resolved 38 conflicted paths with explicit ownership decisions:
- keep strict invalid-ACP-model rejection in production and tests
- restamp finish/error attention on each later outcome while protecting
  pending permission attention
- port chat find onto upstream combined history/live LegendList rows with
  sourceId aliases, disclosure-hold/bottom-anchor detach, one animation-frame
  jump delay, latest-index lookup and cancellation
- keep menu-owned package script discovery with screen-owned restart actions
- keep retained history-go behavior in the beta keyboard pipeline and fork
  Cmd/Ctrl+[ ] bindings, workspace on Cmd/Ctrl+Alt+[ ]

Recovered round-8 resolution patch applied once; all conflict markers cleared,
git diff --check clean. Native message-scroll helper and focused tests included.
Not yet formatted, built, typechecked or gated.
Bring the latest validated custom head (298af48, including 465e16 shared-usage
and model-preference fixes plus the Claude close fixture adaptation) onto the
retained basket branch. Automatic merge, no conflicts.
- drop the stale getCommitFileDiff import: upstream moved commit file reads
  behind CheckoutDiffManager.readCommitFile, which the resolved handler uses
- pass viewMatch through the local fork PR lookup, matching the upstream
  resolver signature
- remove the unused durableTimelineHasRows destructure; the flag still
  reaches initialRecordFields through params
- workspace draft tab: keep the beta dock structure; drop the stale basket
  dock content, local capability override and dead imports
- plan handoff: carry agent.options as draft providerOptions; adapt fixture
- project PR overlay: use beta useGlobalOverlayLayer and
  useOverlayRegistration with Escape registration
- compact tab switcher: pass the artifact and find-in-chat handlers
- workspace scripts test: complete the typed start response fixture
- remove the pre-beta use-keyboard-shortcuts hook; its history-go behavior
  and bindings live in the beta keyboard pipeline
Add the direct fixture the independent PR28 review flagged as P3: a
nonrestoring provider reports a canonical alias distinct from the requested
model, config keeps the requested alias across refreshes while the observed
name is unchanged, and adopts once the observed model genuinely changes.

Includes formatter output for the reconciled overlay and agent-manager seams.
- split fork-aware PR resolution into focused helpers, preserving lookup
  order and the viewMatch union
- extract supported config patch preparation from applySupportedPatch
- remove a duplicate switcher render in the compact header and add the
  artifact/find handlers to the single switcher
- extract agent panel dock content/overlay so complexity stays under the
  project threshold
- drop duplicate AgentStorage import, duplicate clientCapabilities key,
  and the shadowed setup identifier
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 426 files, which is 126 over the limit of 300.

To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch.

Usage-priced reviews support at most 300 files.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 13e7a830-c6b5-43fe-93b8-f50ce3a6c7fc
Commits

Reviewing files that changed from the base of the PR and between c0c6ad9 and 5b1b7cb.

Files ignored due to path filters: 6

  • docs/artifact-feed.png is excluded by !**/*.png
  • fork/plans/tmad-port/evidence/P6-runtime/p6-final-enabled-runtime.log is excluded by !**/*.log
  • fork/plans/tmad-port/evidence/P6-runtime/p6-frozen-voice-client-server-tests.log is excluded by !**/*.log
  • fork/plans/tmad-port/evidence/P6-runtime/p6-full-custom-voice-app-tests.log is excluded by !**/*.log
  • fork/plans/tmad-port/evidence/P6-runtime/p6-full-custom-voice-client-server-tests.log is excluded by !**/*.log
  • fork/plans/tmad-port/evidence/P6-runtime/p6-noqueue-custom-runtime.log is excluded by !**/*.log
Files selected for processing: 426

  • .oxlintrc.json
  • CLAUDE.md
  • docs/architecture.md
  • docs/companion-stream.md
  • docs/custom-providers.md
  • docs/design.md
  • docs/expo-router.md
  • docs/forge-providers.md
  • docs/glossary.md
  • docs/queue-mirroring.md
  • docs/service-proxy.md
  • docs/terminal-activity.md
  • docs/terminal-worker.md
  • fork/CHANGELOG.md
  • fork/campaign/upgrade-0.12.0.manifest.txt
  • fork/handover-beta-upgrade-u2a-2026-10-17.md
  • fork/handover-beta-upgrade-u2b-2026-10-17.md
  • fork/handover-beta-upgrade-u2c-2026-10-17.md
  • fork/handover-beta-upgrade-u2d-2026-10-17.md
  • fork/handover-beta-upgrade-u2e-2026-10-18.md
  • fork/handover-beta-upgrade-u2f-2026-10-18.md
  • fork/handover-beta-upgrade-u3-6762-2026-10-18.md
  • fork/handover-beta-upgrade-u3-7057-2026-10-18.md
  • fork/handover-beta-upgrade-u3-7062-2026-10-18.md
  • fork/handover-beta-upgrade-u3-7106-2026-10-18.md
  • fork/handover-beta-upgrade-u3-7146-2026-10-18.md
  • fork/handover-beta-upgrade-u3-7169-2026-10-18.md
  • fork/handover-beta-upgrade-u3-7179-2026-10-18.md
  • fork/plans/tmad-desvio-0.11.1.md
  • fork/plans/tmad-maintained-port-plan.md
  • fork/plans/tmad-port-work-items.md
  • fork/plans/tmad-port/STATUS.md
  • fork/plans/tmad-port/briefs/COMMON.md
  • fork/plans/tmad-port/briefs/ORCHESTRATOR.md
  • fork/plans/tmad-port/briefs/brief-P0.md
  • fork/plans/tmad-port/briefs/brief-P2.md
  • fork/plans/tmad-port/briefs/brief-TM01.md
  • fork/plans/tmad-port/briefs/brief-TM02.md
  • fork/plans/tmad-port/briefs/brief-TM03.md
  • fork/plans/tmad-port/briefs/brief-TM04.md
  • fork/plans/tmad-port/briefs/brief-TM07.md
  • fork/plans/tmad-port/evidence/.baseline-merge-status.txt
  • fork/plans/tmad-port/evidence/.manifest-refs.txt
  • fork/plans/tmad-port/evidence/P0-feature-map.md
  • fork/plans/tmad-port/evidence/P0-inputs.txt
  • fork/plans/tmad-port/evidence/P0.md
  • fork/plans/tmad-port/evidence/P2.md
  • fork/plans/tmad-port/evidence/P6-assembly-2026-10-08.md
  • fork/plans/tmad-port/evidence/P6-conflict-resolution-log-2026-10-08.md
  • fork/plans/tmad-port/evidence/P6-runtime/README.md
  • fork/plans/tmad-port/evidence/P6-runtime/pending-fixture.json.txt
  • fork/plans/tmad-port/evidence/P6-runtime/queue-removal-enabled-runtime-check.ts.txt
  • fork/plans/tmad-port/evidence/P6-runtime/queue-removal-runtime-check.ts.txt
  • fork/plans/tmad-port/evidence/TM-01.md
  • fork/plans/tmad-port/evidence/TM-02.md
  • fork/plans/tmad-port/evidence/TM-03.md
  • fork/plans/tmad-port/evidence/TM-04-2026-10-08.md
  • fork/plans/tmad-port/evidence/TM-07.md
  • fork/plans/tmad-port/evidence/desvio-0.11.1-focused-tests.txt
  • fork/plans/tmad-port/evidence/desvio-0.11.1-runtime.txt
  • fork/plans/tmad-port/evidence/manifest-frozen-2026-10-02.txt
  • fork/plans/tmad-port/evidence/pluto-cli-typecheck-2026-10-08.md
  • fork/plans/tmad-port/evidence/pluto-readiness-2026-10-08.md
  • fork/plans/tmad-port/evidence/pluto-side-conversation-events-2026-10-08.md
  • fork/plans/tmad-port/evidence/pluto-side-conversation-review-2026-10-08.md
  • fork/plans/tmad-port/evidence/review-P0.md
  • fork/plans/tmad-port/evidence/review-P2.md
  • fork/plans/tmad-port/evidence/review-P6-final-2026-10-08.md
  • fork/plans/tmad-port/evidence/review-TM-01-delta.md
  • fork/plans/tmad-port/evidence/review-TM-01.md
  • fork/plans/tmad-port/evidence/review-TM-02.md
  • fork/plans/tmad-port/evidence/review-TM-03.md
  • fork/plans/tmad-port/evidence/review-TM-04-2026-10-08.md
  • fork/plans/tmad-port/evidence/review-TM-07.md
  • fork/plans/tmad-port/evidence/stream-rollback.md
  • packages/app/e2e/browser/agent-message-submission.spec.ts
  • packages/app/e2e/browser/agent-stream-ui.spec.ts
  • packages/app/e2e/browser/branch-switcher.spec.ts
  • packages/app/e2e/browser/chat-find.spec.ts
  • packages/app/e2e/browser/file-editing.spec.ts
  • packages/app/e2e/browser/pinned-prompt.spec.ts
  • packages/app/e2e/browser/plan-card-markdown.spec.ts
  • packages/app/e2e/browser/project-pull-requests.spec.ts
  • packages/app/e2e/browser/provider-account-create.spec.ts
  • packages/app/e2e/browser/provider-removal.spec.ts
  • packages/app/e2e/browser/viewed-agent-timelines.spec.ts
  • packages/app/e2e/browser/workspace-package-scripts.spec.ts
  • packages/app/e2e/support/helpers/branch-switcher.ts
  • packages/app/e2e/support/helpers/daemon-websocket-gate.ts
  • packages/app/e2e/support/helpers/e2e-worker.ts
  • packages/app/e2e/support/helpers/plugin-buttons.ts
  • packages/app/e2e/support/helpers/seed-client.ts
  • packages/app/e2e/support/helpers/settings.ts
  • packages/app/e2e/support/helpers/workspace-setup.ts
  • packages/app/e2e/support/helpers/workspace-ui.ts
  • packages/app/package.json
  • packages/app/scripts/generate-voice-failure-phrases.mjs
  • packages/app/src/agent-stream/chat-find/index.tsx
  • packages/app/src/agent-stream/chat-find/matches.test.ts
  • packages/app/src/agent-stream/chat-find/matches.ts
  • packages/app/src/agent-stream/chat-find/native-viewport.test.ts
  • packages/app/src/agent-stream/chat-find/native-viewport.ts
  • packages/app/src/agent-stream/chat-find/ranges.browser.test.ts
  • packages/app/src/agent-stream/disclosure.browser.test.tsx
  • packages/app/src/agent-stream/native-message-scroll.test.ts
  • packages/app/src/agent-stream/native-message-scroll.ts
  • packages/app/src/agent-stream/pinned-prompt/model.test.ts
  • packages/app/src/agent-stream/pinned-prompt/model.ts
  • packages/app/src/agent-stream/pinned-prompt/pinned-prompt.tsx
  • packages/app/src/agent-stream/pinned-prompt/pinned-prompt.web.tsx
  • packages/app/src/agent-stream/pinned-prompt/use-pinned-prompt.ts
  • packages/app/src/agent-stream/presentation.ts
  • packages/app/src/agent-stream/reading-signal.ts
  • packages/app/src/agent-stream/strategy-native.tsx
  • packages/app/src/agent-stream/strategy-web.test.tsx
  • packages/app/src/agent-stream/strategy-web.tsx
  • packages/app/src/agent-stream/turn-footer.tsx
  • packages/app/src/agent-stream/view.tsx
  • packages/app/src/app/_layout.tsx
  • packages/app/src/app/new.tsx
  • packages/app/src/artifacts/feed.tsx
  • packages/app/src/assistant-file-links/parse.test.ts
  • packages/app/src/assistant-file-links/parse.ts
  • packages/app/src/assistant-file-links/path-open.test.ts
  • packages/app/src/assistant-file-links/path-open.ts
  • packages/app/src/assistant-selection-copy/content.browser.test.ts
  • packages/app/src/audio/audio-engine.native.test.ts
  • packages/app/src/audio/audio-engine.native.ts
  • packages/app/src/audio/audio-engine.web.test.ts
  • packages/app/src/audio/audio-engine.web.ts
  • packages/app/src/audio/playback.test.ts
  • packages/app/src/audio/playback.ts
  • packages/app/src/command-center/agent-control-contributions.ts
  • packages/app/src/companion-stream/feed.test.tsx
  • packages/app/src/companion-stream/feed.tsx
  • packages/app/src/companion-stream/model.test.ts
  • packages/app/src/companion-stream/model.ts
  • packages/app/src/components/agent-view-switcher.tsx
  • packages/app/src/components/combined-model-selector.tsx
  • packages/app/src/components/message.tsx
  • packages/app/src/components/model-browser.tsx
  • packages/app/src/components/plan-card.tsx
  • packages/app/src/components/plan-copy-actions.tsx
  • packages/app/src/components/plan-handoff-button.tsx
  • packages/app/src/components/plan-handoff.test.tsx
  • packages/app/src/components/plan-handoff.ts
  • packages/app/src/components/provider-account-sheet.tsx
  • packages/app/src/components/provider-icon-name.test.ts
  • packages/app/src/components/provider-icon-name.ts
  • packages/app/src/components/provider-icons.ts
  • packages/app/src/components/realtime-voice-overlay.test.tsx
  • packages/app/src/components/realtime-voice-overlay.tsx
  • packages/app/src/components/sidebar-workspace-list.tsx
  • packages/app/src/components/sidebar/project-leading-visual.tsx
  • packages/app/src/components/sidebar/sidebar-workspace-menu.tsx
  • packages/app/src/components/sidebar/sidebar-workspace-row-content.tsx
  • packages/app/src/components/sidebar/workspace-meta-row/index.tsx
  • packages/app/src/components/sidebar/workspace-meta-row/meta-items.test.ts
  • packages/app/src/components/sidebar/workspace-meta-row/service-summary.test.ts
  • packages/app/src/components/sidebar/workspace-meta-row/service-summary.ts
  • packages/app/src/components/terminal-emulator-contract.ts
  • packages/app/src/components/terminal-emulator-native-grid.native.tsx
  • packages/app/src/components/terminal-emulator.tsx
  • packages/app/src/components/terminal-pane.tsx
  • packages/app/src/components/ui/segmented-control.tsx
  • packages/app/src/composer/actions.test.ts
  • packages/app/src/composer/actions.ts
  • packages/app/src/composer/agent-controls/model-sheet.tsx
  • packages/app/src/composer/index.tsx
  • packages/app/src/composer/input/input.tsx
  • packages/app/src/composer/input/state.test.ts
  • packages/app/src/composer/input/state.ts
  • packages/app/src/composer/queue-sync.test.ts
  • packages/app/src/composer/queue-sync.ts
  • packages/app/src/contexts/session-context.tsx
  • packages/app/src/contexts/session-queue-resume.test.tsx
  • packages/app/src/contexts/voice-context.tsx
  • packages/app/src/data/provider-icons.ts
  • packages/app/src/file-panels/source/file-actions.tsx
  • packages/app/src/file-panels/source/panel.tsx
  • packages/app/src/file-panels/source/toolbar.tsx
  • packages/app/src/git/use-forge-search-query.test.ts
  • packages/app/src/git/use-forge-search-query.ts
  • packages/app/src/hooks/sidebar-workspaces-view-model.test.ts
  • packages/app/src/hooks/sidebar-workspaces-view-model.ts
  • packages/app/src/hooks/use-sidebar-workspaces-list.ts
  • packages/app/src/hooks/use-status-pulse.browser.test.tsx
  • packages/app/src/hooks/use-status-pulse.ts
  • packages/app/src/i18n/resources/ar.ts
  • packages/app/src/i18n/resources/en.ts
  • packages/app/src/i18n/resources/es.ts
  • packages/app/src/i18n/resources/fr.ts
  • packages/app/src/i18n/resources/ja.ts
  • packages/app/src/i18n/resources/ko.ts
  • packages/app/src/i18n/resources/pt-BR.ts
  • packages/app/src/i18n/resources/ru.ts
  • packages/app/src/i18n/resources/zh-CN.ts
  • packages/app/src/keyboard/actions.ts
  • packages/app/src/keyboard/keyboard-shortcuts.test.ts
  • packages/app/src/keyboard/keyboard-shortcuts.ts
  • packages/app/src/keyboard/route-shortcut.test.ts
  • packages/app/src/keyboard/route-shortcut.ts
  • packages/app/src/keyboard/use-shortcuts.ts
  • packages/app/src/navigation/history/model.test.ts
  • packages/app/src/navigation/history/model.ts
  • packages/app/src/navigation/history/record-location.test.ts
  • packages/app/src/navigation/history/recorder.test.tsx
  • packages/app/src/navigation/history/recorder.tsx
  • packages/app/src/navigation/history/replay.test.ts
  • packages/app/src/navigation/history/replay.ts
  • packages/app/src/navigation/history/select-active-tab.test.ts
  • packages/app/src/navigation/history/select-active-tab.ts
  • packages/app/src/navigation/history/store.test.ts
  • packages/app/src/navigation/history/store.ts
  • packages/app/src/panels/agent-panel.tsx
  • packages/app/src/provider-accounts/provider-account-form-model.test.ts
  • packages/app/src/provider-accounts/provider-account-form-model.ts
  • packages/app/src/provider-accounts/use-provider-account-form-model.ts
  • packages/app/src/provider-selection/provider-selection.test.ts
  • packages/app/src/provider-selection/provider-selection.ts
  • packages/app/src/runtime/host-features.test.ts
  • packages/app/src/runtime/host-runtime.ts
  • packages/app/src/runtime/replica-cache/index.ts
  • packages/app/src/screens/new-workspace-screen.tsx
  • packages/app/src/screens/project-pull-requests/checks-view.tsx
  • packages/app/src/screens/project-pull-requests/checks.test.ts
  • packages/app/src/screens/project-pull-requests/checks.ts
  • packages/app/src/screens/project-pull-requests/model.test.ts
  • packages/app/src/screens/project-pull-requests/model.ts
  • packages/app/src/screens/project-pull-requests/overlay-frame.tsx
  • packages/app/src/screens/project-pull-requests/overlay-frame.web.tsx
  • packages/app/src/screens/project-pull-requests/shortcut.tsx
  • packages/app/src/screens/project-pull-requests/view.tsx
  • packages/app/src/screens/settings/providers-section.test.tsx
  • packages/app/src/screens/settings/providers-section.tsx
  • packages/app/src/screens/workspace/compact-workspace-header/tab-switcher.tsx
  • packages/app/src/screens/workspace/scripts/workspace-scripts-button.test.tsx
  • packages/app/src/screens/workspace/scripts/workspace-scripts-button.tsx
  • packages/app/src/screens/workspace/scripts/workspace-scripts-menu-pages.tsx
  • packages/app/src/screens/workspace/workspace-desktop-tabs-row.tsx
  • packages/app/src/screens/workspace/workspace-header-branch-options.test.ts
  • packages/app/src/screens/workspace/workspace-header-branch-options.ts
  • packages/app/src/screens/workspace/workspace-header-branches.tsx
  • packages/app/src/screens/workspace/workspace-header-menu.tsx
  • packages/app/src/screens/workspace/workspace-header-project-row.tsx
  • packages/app/src/screens/workspace/workspace-header-source.ts
  • packages/app/src/screens/workspace/workspace-recent-agents-menu.tsx
  • packages/app/src/screens/workspace/workspace-screen.tsx
  • packages/app/src/screens/workspace/workspace-source-of-truth.test.ts
  • packages/app/src/screens/workspace/workspace-tab-menu.ts
  • packages/app/src/screens/workspace/workspace-tab-trailing-accessory.test.tsx
  • packages/app/src/screens/workspace/workspace-tab-trailing-accessory.tsx
  • packages/app/src/stores/agent-view-store.ts
  • packages/app/src/stores/navigation-active-workspace-store/navigation.ts
  • packages/app/src/stores/queue-outbox-store/index.ts
  • packages/app/src/stores/queue-outbox-store/model.test.ts
  • packages/app/src/stores/queue-outbox-store/model.ts
  • packages/app/src/stores/session-store.test.ts
  • packages/app/src/stores/session-store.ts
  • packages/app/src/terminal/runtime/terminal-emulator-runtime.test.ts
  • packages/app/src/terminal/runtime/terminal-emulator-runtime.ts
  • packages/app/src/utils/agent-snapshots.ts
  • packages/app/src/utils/host-routes.ts
  • packages/app/src/utils/provider-definitions.ts
  • packages/app/src/voice/input-receipt-cue.ts
  • packages/app/src/voice/voice-failure-cue.ts
  • packages/app/src/voice/voice-failure-phrases.mulaw.ts
  • packages/app/src/voice/voice-failure.test.ts
  • packages/app/src/voice/voice-failure.ts
  • packages/app/src/voice/voice-runtime.test.ts
  • packages/app/src/voice/voice-runtime.ts
  • packages/app/src/workspace-tabs/recently-closed.test.ts
  • packages/app/src/workspace-tabs/recently-closed.ts
  • packages/app/test-stubs/lucide-react-native.ts
  • packages/app/vitest.config.ts
  • packages/cli/src/commands/agent/artifacts-scan.ts
  • packages/cli/src/commands/agent/index.ts
  • packages/cli/src/commands/agent/run.test.ts
  • packages/cli/src/commands/agent/run.ts
  • packages/cli/src/commands/provider/add.test.ts
  • packages/cli/src/commands/provider/add.ts
  • packages/cli/src/commands/provider/index.ts
  • packages/cli/src/commands/provider/ls.ts
  • packages/cli/src/commands/provider/rm.ts
  • packages/cli/src/commands/provider/shared.ts
  • packages/cli/tests/15-provider.test.ts
  • packages/cli/tests/46-daemon-terminal-worker-upgrade.test.ts
  • packages/client/src/connection/index.ts
  • packages/client/src/daemon-client.test.ts
  • packages/client/src/daemon-client.ts
  • packages/desktop/e2e/daemon-lifecycle.e2e.mjs
  • packages/desktop/src/daemon/quit-lifecycle.test.ts
  • packages/desktop/src/daemon/quit-lifecycle.ts
  • packages/desktop/src/main.ts
  • packages/protocol/src/agent-types.ts
  • packages/protocol/src/client-capabilities.ts
  • packages/protocol/src/companion-stream.ts
  • packages/protocol/src/messages.agent-queue.test.ts
  • packages/protocol/src/messages.artifacts.test.ts
  • packages/protocol/src/messages.checkout-pr-schema.test.ts
  • packages/protocol/src/messages.companion-update-entry.test.ts
  • packages/protocol/src/messages.ts
  • packages/protocol/src/messages.voice-flow.test.ts
  • packages/protocol/src/messages.wire-compat.test.ts
  • packages/protocol/src/provider-manifest.ts
  • packages/server/src/server/agent-queue/send-or-queue.test.ts
  • packages/server/src/server/agent-queue/send-or-queue.ts
  • packages/server/src/server/agent-queue/service.test.ts
  • packages/server/src/server/agent-queue/service.ts
  • packages/server/src/server/agent-queue/store.test.ts
  • packages/server/src/server/agent-queue/store.ts
  • packages/server/src/server/agent/agent-manager.test.ts
  • packages/server/src/server/agent/agent-manager.ts
  • packages/server/src/server/agent/agent-projections.test.ts
  • packages/server/src/server/agent/agent-projections.ts
  • packages/server/src/server/agent/agent-prompt.test.ts
  • packages/server/src/server/agent/agent-prompt.ts
  • packages/server/src/server/agent/agent-sdk-types.ts
  • packages/server/src/server/agent/agent-storage.test.ts
  • packages/server/src/server/agent/agent-storage.ts
  • packages/server/src/server/agent/agent-timeline-store-types.ts
  • packages/server/src/server/agent/agent-timeline-store.ts
  • packages/server/src/server/agent/artifacts/backfill.test.ts
  • packages/server/src/server/agent/artifacts/collector.test.ts
  • packages/server/src/server/agent/artifacts/collector.ts
  • packages/server/src/server/agent/companion-stream.test.ts
  • packages/server/src/server/agent/companion-stream.ts
  • packages/server/src/server/agent/lifecycle-command.ts
  • packages/server/src/server/agent/mcp-server.test.ts
  • packages/server/src/server/agent/mcp-shared.ts
  • packages/server/src/server/agent/provider-snapshot-manager.test.ts
  • packages/server/src/server/agent/provider-snapshot-manager.ts
  • packages/server/src/server/agent/providers/acp-agent.test.ts
  • packages/server/src/server/agent/providers/acp-agent.ts
  • packages/server/src/server/agent/providers/claude/agent.live-settings.test.ts
  • packages/server/src/server/agent/providers/claude/agent.test.ts
  • packages/server/src/server/agent/providers/claude/agent.ts
  • packages/server/src/server/agent/providers/codex-async-questions.test.ts
  • packages/server/src/server/agent/providers/codex/tool-call-mapper.test.ts
  • packages/server/src/server/agent/providers/codex/tool-call-mapper.ts
  • packages/server/src/server/agent/providers/generic-acp-agent.request-errors.test.ts
  • packages/server/src/server/agent/providers/omp/agent.test.ts
  • packages/server/src/server/agent/providers/opencode/test-utils/v2-harness.ts
  • packages/server/src/server/agent/timeline-page-bounds.test.ts
  • packages/server/src/server/agent/timeline-page-bounds.ts
  • packages/server/src/server/agent/tools/paseo-tools.ts
  • packages/server/src/server/agent/tts-manager.test.ts
  • packages/server/src/server/agent/tts-manager.ts
  • packages/server/src/server/atomic-file.ts
  • packages/server/src/server/authorization/operation-permissions.ts
  • packages/server/src/server/bootstrap.smoke.test.ts
  • packages/server/src/server/bootstrap.test.ts
  • packages/server/src/server/bootstrap.ts
  • packages/server/src/server/connected-hosts/hosts.e2e.test.ts
  • packages/server/src/server/creation/index.test.ts
  • packages/server/src/server/creation/index.ts
  • packages/server/src/server/daemon-config-store.test.ts
  • packages/server/src/server/daemon-config-store.ts
  • packages/server/src/server/daemon-e2e/agent-queue-mirroring.e2e.test.ts
  • packages/server/src/server/daemon-e2e/claude-settings-mid-turn.real.e2e.test.ts
  • packages/server/src/server/daemon-e2e/omp.real.e2e.test.ts
  • packages/server/src/server/daemon-e2e/timeline-byte-bound.e2e.test.ts
  • packages/server/src/server/hub/daemon-executions.test.ts
  • packages/server/src/server/hub/test-utils/relationship-harness.ts
  • packages/server/src/server/message-receipts/index.test.ts
  • packages/server/src/server/message-receipts/index.ts
  • packages/server/src/server/persistence-hooks.ts
  • packages/server/src/server/plugins/compiler-build.ts
  • packages/server/src/server/plugins/compiler.test.ts
  • packages/server/src/server/plugins/index.ts
  • packages/server/src/server/plugins/usage-sources/index.ts
  • packages/server/src/server/plugins/usage-sources/provider-account-discovery.test.ts
  • packages/server/src/server/plugins/usage-sources/provider-accounts.test.ts
  • packages/server/src/server/plugins/usage-sources/provider-accounts.ts
  • packages/server/src/server/script-health-monitor.test.ts
  • packages/server/src/server/script-status-projection.ts
  • packages/server/src/server/session.test.ts
  • packages/server/src/server/session.ts
  • packages/server/src/server/session.voice-mcp-config.test.ts
  • packages/server/src/server/session/checkout/checkout-session.test.ts
  • packages/server/src/server/session/checkout/checkout-session.ts
  • packages/server/src/server/session/voice/index.test.ts
  • packages/server/src/server/session/voice/index.ts
  • packages/server/src/server/session/voice/voice-recognition-issue.test.ts
  • packages/server/src/server/session/voice/voice-recognition-issue.ts
  • packages/server/src/server/session/voice/voice-session.test.ts
  • packages/server/src/server/session/voice/voice-session.ts
  • packages/server/src/server/session/voice/voice-turn-controller.test.ts
  • packages/server/src/server/session/voice/voice-turn-controller.ts
  • packages/server/src/server/session/workspace-scripts/workspace-scripts-service.test.ts
  • packages/server/src/server/session/workspace-scripts/workspace-scripts-service.ts
  • packages/server/src/server/test-utils/session-stubs.ts
  • packages/server/src/server/voice-config.ts
  • packages/server/src/server/voice-types.ts
  • packages/server/src/server/websocket-server.provider-rename.test.ts
  • packages/server/src/server/websocket-server.relay-reconnect.test.ts
  • packages/server/src/server/websocket-server.terminal-notifications.test.ts
  • packages/server/src/server/websocket-server.ts
  • packages/server/src/server/websocket/physical-socket.ts
  • packages/server/src/server/workspace-script-runtime-store.ts
  • packages/server/src/server/workspace-scripts/package-scripts.test.ts
  • packages/server/src/server/workspace-scripts/package-scripts.ts
  • packages/server/src/server/worktree-bootstrap.test.ts
  • packages/server/src/server/worktree-bootstrap.ts
  • packages/server/src/services/forge-service.ts
  • packages/server/src/services/github-service.test.ts
  • packages/server/src/services/github-service.ts
  • packages/server/src/terminal/shell-integration/cmd/report-command-finished.cmd
  • packages/server/src/terminal/terminal-worker-runtime.test.ts
  • packages/server/src/terminal/terminal-worker-runtime.ts
  • packages/server/src/terminal/terminal.test.ts
  • packages/server/src/terminal/terminal.ts
  • packages/server/src/terminal/worker-terminal-manager.test.ts
  • packages/server/src/terminal/worker-terminal-manager.ts
  • packages/server/src/utils/checkout-git.test.ts
  • packages/server/src/utils/checkout-git.ts
  • packages/server/src/utils/tree-kill.test.ts
  • packages/server/src/utils/tree-kill.ts
  • packages/server/src/utils/worktree-metadata.ts
  • plugins/account-usage.test.ts
  • plugins/claude-usage-source/server/usage.ts
  • plugins/claude-usage-source/shared/input.ts
  • plugins/codex-usage-source/server/usage.ts
  • plugins/codex-usage-source/shared/input.ts
  • plugins/copilot-usage-source/server/usage.ts
  • plugins/copilot-usage-source/shared/input.ts

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

- footer timing grows with its wrapped second line when the retained pin
  adds a third control at a narrow transcript width
- pinned-prompt helper scrolls the prompt row wrapper clear of the reading
  line, not just the bubble inside it
- host-channel flow-control test holds a bounded timeline page and paginates
  the remaining pages instead of waiting for an oversized binary chunk
@camerontaylor
camerontaylor marked this pull request as ready for review November 12, 2026 14:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T14:14:56.811383Z 5b1b7cb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cq-review

cq-review Bot commented Nov 12, 2026

Copy link
Copy Markdown

Independent review (GLM): PASS for 5b1b7cbda3017f186c36e5b8fc0a1ca0a12f8f74

Reviewer: GLM (jcode/glm-5.3-flash), independent of the authoring DeepSeek release lane (cf2c). Review round 1 for this reviewer; verdict deferred across pins 9989643 → d2114d2 → ed1ccb6/a257b7a → 287e394 → 5b1b7cb as the author pushed fixes, per the coordinating lead. The verdict covers only the exact SHA in the header line.

Scope and method

The PR's base branch is custom (c0c6ad9), not main — the PR carries the retained 0.15.2 basket onto synced upstream v0.16.0-beta.2, and custom already contains the reviewed PR #28 promotion (298af48b). Review scope is therefore c0c6ad9..5b1b7cbd: 229 commits, 430 files, +44379/−1928. I read the named carry areas in full at the final head (keyboard history bindings, ACP model-selection ownership and termination policy, the native chat-find scroller port, scripts/, tests), audited the delta at blob level (scripts/ has zero changed blobs vs base; the post-9989643 fix window is test-side only except two small production lines: turn-footer.tsx height→minHeight and the message.tsx footer flexWrap/minWidth wrap fix), and verified each fix commit against the failure it addresses (causal and non-weakening — details below). Exact-head CI plus targeted evidence replaced local suite runs, per review policy; no full suite, watch, or coverage was run locally.

CI and census at the exact head

  • ci.yml run 43228695910: completed/success at 5b1b7cbd — app-tests, cli-tests ×3, desktop-tests (ubuntu), linux, quality, server-tests (ubuntu + macos), typecheck, and all 8 playwright shards green. Windows entries skipping = change-gated, not applicable.
  • desktop-packages.yml run 43228696107: success. fork-ci.yml run 43228696347: success.
  • Review threads: 0 open. PR is OPEN and marked ready for review.

Fix-window verification (each failure → fix → verified causal)

  1. Merge-seam test failures at d2114d21 (agent-projections 2-arg buildStoredAgentPayload calls violating the base-required 3-arg signature; mcp-server listDraftControls stub lacking the real shape; opencode v2 harness rejecting the real instructions.entry.put the production v2/session.ts:201 emits; github-service fork-PR fixture missing the [] array page the CLI parser consumes): fixed in ed1ccb6, format-only follow-up a257b7a. All four fixes restore real seams; none masks behavior.
  2. hosts.e2e timeout + pinned-prompt failures at a257b7a→287e3942: the held-frame test matched the real text-page fetch_agent_timeline_response wire message instead of expecting one binary frame, with a pagination drain loop; the pinned-prompt spec now targets [data-history-row-id] rows (real attribute, strategy-web.tsx:1270). Both suites green at the final head.
  3. Footer timing failures at 287e3942: turn-footer.tsx height→minHeight alone did not fix painted-line bounds at narrow widths; 5b1b7cbd added flexWrap: "wrap" + labelButton minWidth: 72 in message.tsx — shard 2/8 then passed. changes-pane context-menu test failed once and passed on retry (transient; green in the final run).
  4. Clarification on earlier evidence: the e2e suite contains zero toHaveScreenshot/snapshot assertions; all PNGs in failure artifacts are page.screenshot context captures, not visual baselines. The shard-2 scroll tests assert real behavior (jump counts, mount balance, page exercise) and passed at the final head. The repeated "already has an active writer" log warnings are the carried fault-injection helper (daemon-websocket-gate.ts:144-146) intentionally reproducing a daemon refusal the sync-retry specs assert against — harness noise, not a defect.

Non-blocking observations (P3)

  1. P3: the PR body cites basket-owner-decisions.md, but no file by that name exists in the tree or history at this head; the ownership decisions are documented across fork/handover-beta-upgrade-*.md. Prose slip in the PR description only.
  2. P3: the PR targets custom while main lags custom, so GitHub's file-count view (main...head) greatly overstates the delta (430 files vs the ~dozen files this PR's own commits touch beyond carried content). Worth a reader's note in the body.

Residual risks

  • The carry is a 229-commit release basket; my review depth was risk-directed (named areas + fix window + blob-level anomaly scan), not line-by-line across all 430 files. CI at the exact head is the primary gate and is green.
  • Screenshot-free e2e means pure visual regressions are not covered by CI; the carry's UI changes (footer wrap, chat-find port) are covered behaviorally instead.
  • Windows CI is change-gated off for this PR; Windows-specific behavior was not exercised.

@camerontaylor
camerontaylor merged commit 1c46a58 into custom Nov 12, 2026
25 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b1b7cbda3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +893 to +896
if (candidate.attempts >= DELIVERY_ATTEMPT_LIMIT) {
return { ...candidate, deliveryState: "failed", lastError: message };
}
return { ...candidate, deliveryState: "pending", lastError: message };

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Hold ambiguous dispatch failures as uncertain

If a provider accepts a prompt but run-start confirmation times out, or writing the completed receipt fails, this catch returns the item to pending even though delivery may have succeeded. MessageReceipts.sendOnce() deliberately retains a pending receipt for such failures, but the next queue attempt increments attemptSeq and uses a new receipt key, bypassing that protection and potentially executing the prompt again. Only confirmed pre-dispatch failures should become automatically retryable; ambiguous outcomes should become uncertain and require an explicit retry.

Useful? React with 👍 / 👎.

Comment on lines +536 to +537
this.publish(result);
return toAgentQueueSnapshot(result.queue);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Resume draining after removing a blocking queue head

When an idle agent's queue is blocked by a failed or uncertain head, discarding that item leaves the next pending prompt stranded: remove() publishes the snapshot but never schedules a drain. There is no running-to-idle transition to wake it, and the session mutation subscriber only broadcasts updates. The same issue occurs when reorder() moves a pending item ahead of a blocked head. Schedule a drain after these mutations so unblocked work runs without another enqueue or manually started turn.

Useful? React with 👍 / 👎.

Comment on lines +524 to +528
if (item.origin === "voice" && this.receipts) {
await this.receipts.recordRemoved({
agentId,
messageId: itemId,
attachmentId: itemId.split(":", 1)[0],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Retain deletion tombstones for typed queue items

If an enqueue reaches the daemon but its acknowledgement is lost, the originating device retains it in its durable outbox. Another device can then delete that queued prompt, but this code records a removal tombstone only for voice items and does not add the deleted ID to drainedIds. On reconnect, flushQueueOutboxForServer() resends the original typed enqueue, and enqueue() admits it again, allowing a prompt the user explicitly discarded to execute. Persist deletion deduplication state for typed items as well as voice items.

Useful? React with 👍 / 👎.

Comment on lines +5985 to +5987
agent.artifacts = collection.artifacts;
this.touchUpdatedAt(agent);
this.emitState(agent);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Discard artifact scan results for replaced agent instances

If an agent is reloaded while its end-of-turn artifact scan is walking the directory, this continuation still updates and emits the old ActiveManagedAgent object. prepareAgentForClosure() removes that instance without changing its lifecycle, and emitState() unconditionally persists and broadcasts it, so the completed scan can overwrite the reloaded agent's stored configuration and publish stale state with a fresh timestamp. Cancelling the collector does not stop a finishTurn() already in progress. Before applying the result, verify that this.agents.get(agent.id) is still the same instance; apply the same protection to the explicit scan path.

Useful? React with 👍 / 👎.

Comment on lines +239 to +240
const surplus = entries.length - COMPANION_ENTRY_LIMIT;
let remaining = surplus;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exclude manual entries when calculating captured-entry surplus

Once a conversation has 50 manual pins or tracked Q&A entries, every newly captured permission, question, or outcome is immediately evicted. The surplus is calculated from all entries, but the eviction loop removes only captured entries, so manual entries consume the entire captured-moment allowance despite having a separate limit of 100. Count only non-manual entries when calculating the surplus so saving notes does not disable the Stream's automatic capture and Needs a reply cards.

Useful? React with 👍 / 👎.

Comment on lines +2203 to +2204
(agentId: string) => {
setFindOpen(normalizedServerId, agentId, true);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Switch to Chat before opening native chat search

On native, selecting Find in chat while the agent's Stream view is selected only sets findOpen; it never changes selectedViews back to chat. ChatAgentReadyContent consequently keeps the chat's RetainedPanel hidden, and the search overlay mounted inside AgentStreamView is hidden with it. The tab-menu action therefore leaves the user on Stream without a visible search field. Select the Chat view before requesting Find so this entry point works regardless of the previously selected view.

Useful? React with 👍 / 👎.

if (metadata.seq <= this.fallbackSeq) return;
this.fallbackEpoch = metadata.epoch;
this.fallbackSeq = metadata.seq;
this.visibleReply = (this.visibleReply + event.item.text).slice(0, 4000);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Retain the final response rather than early narration for voice

For a turn that does not invoke speak, every assistant message is concatenated into visibleReply, including commentary before tool calls, and only the first 4,000 characters survive. If that commentary fills the buffer, the actual final answer is discarded completely and fallback playback reads only the earlier narration. handleAgentEvent() currently ignores tool-call boundaries instead of resetting the response buffer. Track the final contiguous assistant response and apply the length bound to that response so voice users hear the result rather than superseded progress text.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.