docs(validation): note fork-PR approval gate in codeowner guidance - #413
Merged
hdamker merged 2 commits intoAug 7, 2026
Merged
Conversation
For a contributor who trips the org's fork-PR approval policy, the CAMARA Validation check doesn't just fail — it's absent from the checks list until a maintainer approves the pending workflow run. SimSwap#276 is a concrete case of this being missed.
Kevsy
reviewed
Aug 6, 2026
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
documentation
What this PR does / why we need it:
Adds a bullet to the "Codeowner guidance" section of
documentation/validation/pull-requests.md. Some pull requests need a maintainer to approve their workflow run before CAMARA Validation can run at all — most commonly, someone's first PR to the repository. Until that happens, the check doesn't fail, it's simply absent from the checks list, which is easy to mistake for "nothing to check."Which issue(s) this PR fixes:
Related to camaraproject/SimSwap#276 — a concrete case of this being missed, on the same PR (SimSwap#273) already surfaced in that issue.
Special notes for reviewers:
Doc-only change; no code or test impact.
Changelog input
Additional documentation
This section can be blank.