Skip to content

Add createdAt and updatedAt fields to brand registration - #129

Merged
GillesInnov35 merged 2 commits into
mainfrom
Add-createdAt-and-updatedAt-new-fields-to-registration
Jul 22, 2026
Merged

Add createdAt and updatedAt fields to brand registration#129
GillesInnov35 merged 2 commits into
mainfrom
Add-createdAt-and-updatedAt-new-fields-to-registration

Conversation

@GillesInnov35

Copy link
Copy Markdown
Contributor

Added createdAt and updatedAt fields with filters to the brand registration API definition.

What type of PR is this?

  • enhancement/feature

What this PR does / why we need it:

include 2 new fields createdAt and updatedAt to the brand registration API definition allowing full management of customer registrations.
To be more useful for operational purposes, fields format is date-time (e.g. 2026-07-16T11:51:30+03:00)

Which issue(s) this PR fixes:

Fixes #123

Added createdAt and updatedAt fields with filters to the brand registration API definition.
@camara-validation

camara-validation Bot commented Jul 17, 2026

Copy link
Copy Markdown

CAMARA Validation — PASS (with warnings)

0 errors, 4 warnings, 24 hints | Profile: standard

View full results

@mohdfarhanakram

mohdfarhanakram commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Nice one, @GillesInnov35 the createdAt/updatedAt response fields are exactly what's needed here, and the full-timestamp format matches what @alpaycetin74 suggested on #123. 👍

One small thought on the added filters: since these are to-the-second timestamps, an exact match is hard to query against - would a range (createdAtAfter/createdAtBefore & updatedAtAfter/updatedAtBefore) be more practical? Happy to help with that as a follow-up either way.

@GillesInnov35

Copy link
Copy Markdown
Contributor Author

@mohdfarhanakram , you're right not easy to query with an equal operator.
In that case of timestamp, .gt or .gt operators are mainly used. It should be specified.
WDYT ?

@alpaycetin74

Copy link
Copy Markdown
Contributor

Hello, in design guidelines section 4.3.2, there is an example to include gt, gte,lt,lte filters for a date type.
I think we can follow this approach for createdAt & updatedAt.
For expiresAt query, we can also include equality.

https://github.com/camaraproject/Commonalities/blob/main/documentation/CAMARA-API-Design-Guide.md#43-filtering

@alpaycetin74 alpaycetin74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@GillesInnov35
GillesInnov35 merged commit b1699f9 into main Jul 22, 2026
3 checks passed
@alpaycetin74
alpaycetin74 deleted the Add-createdAt-and-updatedAt-new-fields-to-registration branch July 22, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add createdAt and updatedAt new fields to registration entity

3 participants