[Added] Add test cases for QoS session creation using an application server list - #587
[Added] Add test cases for QoS session creation using an application server list#587eric-murray wants to merge 4 commits into
Conversation
RandyLevensalor
left a comment
There was a problem hiding this comment.
A few nits.
I think the[] should be replaced by [*] or drop them as appropriate.
From the AI:
- RFC 9535 (JSONPath spec) — [*] is the standard wildcard selector for "all elements of an array." Bare [] is not valid JSONPath syntax for "the whole array" in the spec at all.
| And the request body property "$.applicationServer.ipAddresses" exists | ||
| And the number of items in request body array "$.applicationServer.ipAddresses[]" is greater than 0 | ||
| And the number of items in request body array "$.applicationServer.ipAddresses[]" is less than 17 | ||
| And each item in request body array "$.applicationServer.ipAddresses[*]" is either a valid IPv4 or valid IPv6 address |
There was a problem hiding this comment.
| And each item in request body array "$.applicationServer.ipAddresses[*]" is either a valid IPv4 or valid IPv6 address | |
| And each item in request body array "$.applicationServer.ipAddresses[*]" is either a valid IPv4 address or valid IPv6 address |
There was a problem hiding this comment.
See my comment #587 (comment)
| And each item in request body array "$.applicationServer.ipAddresses[*]" is either a valid IPv4 or valid IPv6 address | |
| And each item in request body array "$.applicationServer.ipAddresses" is either a valid IPv4 address or valid IPv6 address |
| Scenario: Invalid values in application server list | ||
| Given the request body property "$.applicationServer.ipAddresses" exists | ||
| And the number of items in request body array "$.applicationServer.ipAddresses[]" is greater than 0 | ||
| And at least one item in request body array "$.applicationServer.ipAddresses[*]" is not a valid single IPv4 or IPv6 address |
There was a problem hiding this comment.
| And at least one item in request body array "$.applicationServer.ipAddresses[*]" is not a valid single IPv4 or IPv6 address | |
| And at least one item in request body array "$.applicationServer.ipAddresses[*]" is not a valid single IPv4 address or IPv6 address |
There was a problem hiding this comment.
| And at least one item in request body array "$.applicationServer.ipAddresses[*]" is not a valid single IPv4 or IPv6 address | |
| And at least one item in request body array "$.applicationServer.ipAddresses" is not a valid single IPv4 address or IPv6 address |
hdamker
left a comment
There was a problem hiding this comment.
Thanks @eric-murray, just two suggestions, rest LGTM
| @quality_on_demand_createSession_04_1_application_server_subnets_provided | ||
| Scenario: Create QoS session for application server subnets | ||
| Given a valid testing device supported by the service, identified by the token or provided in the request body | ||
| And the request body properties "$.applicationServer.ipv4Address" and/or "$.applicationServer.ipv6Address" exist and have valid values |
There was a problem hiding this comment.
The claim of the scenario is "Create QoS session for application server subnets". But also a single IPv4 or IPv6 address would fulfill "valid values" (the subnet is optional). To pin to subnet notation, it needs to say "include a subnet mask" in some form.
| And the request body properties "$.applicationServer.ipv4Address" and/or "$.applicationServer.ipv6Address" exist and have valid values | |
| And the request body properties "$.applicationServer.ipv4Address" and/or "$.applicationServer.ipv6Address" exist and have valid values which include a subnet mask |
| @quality_on_demand_createSession_400.12_empty_application_server_list | ||
| Scenario: Empty application server list | ||
| Given the request body property "$.applicationServer.ipAddresses" exists | ||
| And the number of items in request body array "$.applicationServer.ipAddresses[]" is equal to 0 |
There was a problem hiding this comment.
I suggest that the references to the array itself should be all plain $.applicationServer.ipAddresses without [ ] or [*] as none of them represents an item.
There are 12 steps to correct:
[] → plain: lines 109, 110, 354, 364, 374, 375, 385, 396
[*] → plain: lines 111, 112, 386, 397
What type of PR is this?
What this PR does / why we need it:
A list of application server addresses can now be specified to identify the application server. This PR adds test cases for this new feature.
Which issue(s) this PR fixes:
Fixes #577
Special notes for reviewers:
None
Changelog input
Additional documentation
None