Conversation
Updated response references and error handling for SMS OTP validation for 403/422/429
Updated the feature file for one-time password SMS sendCode operation for 422/403/429 error handling scenarios.
CAMARA Validation — PASS (with warnings)0 errors, 1 warnings, 1 hints | Profile: standard |
|
This is necessary to create the snapshot? @camaraproject/otp-validation_codeowners |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Change http code:
ONE_TIME_PASSWORD_SMS.MAX_OTP_CODES_EXCEEDED was 403, now 429
ONE_TIME_PASSWORD_SMS.PHONE_NUMBER_NOT_ALLOWED was 403, now 422
ONE_TIME_PASSWORD_SMS.PHONE_NUMBER_BLOCKED was 403, now 422
Which issue(s) this PR fixes:
Fixes #123
Special notes for reviewers:
This is a breaking change modification
Changelog input
Additional documentation
This section can be blank.