Commonalities alignment and fix validation warnings - #47
Conversation
Updated error response documentation and references to CAMARA commonalities. Added additional error response details and refined descriptions for various components.
CAMARA Validation — PASS0 errors, 0 warnings, 6 hints | Profile: standard |
Removed x-correlator header and parameter references.
Clarified optional properties and response details for age verification.
Increased maxLength for MiddleNames from 100 to 150.
|
Thanks, @GillesInnov35. A primitive question for clarification, please. You have deleted Lines 239 - 244 related to And, as for other parameters/properties, descriptions remain in the age_verification yaml, because these descriptions are not included in the CAMARA_common.yaml. Aslo correct? Thanks, |
ToshiWakayama-KDDI
left a comment
ToshiWakayama-KDDI
left a comment
There was a problem hiding this comment.
Thanks, @GillesInnov35 . LGTM.
|
Sorry, @GillesInnov35, that I approved the PR and reset it. I am still waiting for your reply to my question...] |
|
Hi @GillesInnov35 , Hi @fernandopradocabrillo , Thanks, |
|
@ToshiWakayama-KDDI , @fernandopradocabrillo , could you take a look and approve if OK for you. Many thanks |
|
NOTE: You can address this point from CAMARA Validation in this PR #47 (comment) or when adjusting RC PR FYI [P-032] Remove API readiness checklist file from API repo — 1 hit documentation/API_documentation/kyc-age-verification-API-Readiness-Checklist.md:1 — [P-032] API readiness checklist file 'documentation/API_documentation/kyc-age-verification-API-Readiness-Checklist.md' should be removed from the API repository; use the canonical ReleaseManagement readiness documentation instead |
Added response schemas for various error codes including 400, 401, 403, 404, and 422 with detailed examples.
ToshiWakayama-KDDI
left a comment
ToshiWakayama-KDDI
left a comment
There was a problem hiding this comment.
Thank you so much, @GillesInnov35 . LGTM.
3 participants
Updated error response documentation and references to CAMARA commonalities. Added additional error response details and refined descriptions for various components.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Commonalities 8.0.0 alignment - https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/789086209/Analysis+of+Commonalities+0.8.0
Artifacts directory restructured for $ref consumption camaraproject/Commonalities#606
Testing artifacts for 400 Syntax Error including empty request body scenario camaraproject/Commonalities#618
Clarification on string `maxLength' value camaraproject/Commonalities#620
Added rule for undeclared properties in request bodies camaraproject/Commonalities#634
Added mandatory info.description templates to common artifacts and samples https://github.com/camaraproject/Commonalities/pull/635Problem description
Commonalities 8.0.0 alignment - https://lf-camaraproject.atlassian.net/wiki/spaces/CAM/pages/789086209/Analysis+of+Commonalities+0.8.0
Expected behavior
Artifacts directory restructured for $ref consumption camaraproject/Commonalities#606
Testing artifacts for 400 Syntax Error including empty request body scenario camaraproject/Commonalities#618
Clarification on string `maxLength' value camaraproject/Commonalities#620
Added rule for undeclared properties in request bodies camaraproject/Commonalities#634
Added mandatory info.description templates to common artifacts and samples camaraproject/Commonalities#635
Which issue(s) this PR fixes:
Fixes #46
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.