Skip to content

bugfix: Replace 422 IDENTIFIER_MISMATCH with eSIM API specific code - #56

Open
rkandoi wants to merge 2 commits into
camaraproject:mainfrom
rkandoi:fix/53-identifier-mismatch-error-code
Open

bugfix: Replace 422 IDENTIFIER_MISMATCH with eSIM API specific code#56
rkandoi wants to merge 2 commits into
camaraproject:mainfrom
rkandoi:fix/53-identifier-mismatch-error-code

Conversation

@rkandoi

@rkandoi rkandoi commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • bug

Which issue(s) this PR fixes:

Fixes #53

  • Remove IDENTIFIER_MISTMATCH
  • Corrected ESimProfileForDownload to only accept EID
  • Clarifications in docs on the use of the dual EID and ICCID identifiers

@rkandoi

rkandoi commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@eric-murray - Please suggest if this is the fix for #53.

@eric-murray

Copy link
Copy Markdown

@eric-murray - Please suggest if this is the fix for #53.

Hi @rkandoi

Yes, fixing the error code was the only requirement for compliance with the Commonalities Design Guide. I can see that you are also working to improve the documentation, which is nobody's favourite task, but really does help potential users understand how to use the API.

Once the PRs are merged, create a new snapshot and I will be able to approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document rationale for allowing both EID and ICCID as request parameters, and fix 422 IDENTIFIER_MISMATCH error code

2 participants