bugfix: Replace 422 IDENTIFIER_MISMATCH with eSIM API specific code - #56
Open
rkandoi wants to merge 2 commits into
Open
bugfix: Replace 422 IDENTIFIER_MISMATCH with eSIM API specific code#56rkandoi wants to merge 2 commits into
rkandoi wants to merge 2 commits into
Conversation
rkandoi
requested review from
XunliYang,
chenfr2-ChinaTelecom and
maheshc01
as code owners
August 6, 2026 05:28
Contributor
Author
|
@eric-murray - Please suggest if this is the fix for #53. |
Hi @rkandoi Yes, fixing the error code was the only requirement for compliance with the Commonalities Design Guide. I can see that you are also working to improve the documentation, which is nobody's favourite task, but really does help potential users understand how to use the API. Once the PRs are merged, create a new snapshot and I will be able to approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Fixes #53
IDENTIFIER_MISTMATCHESimProfileForDownloadto only accept EIDEIDandICCIDidentifiers