Release Review: DeviceRoamingStatus r2.1 (rc Sync26) - #88
Conversation
CAMARA Validation — PASS0 errors, 0 warnings, 3 hints | Profile: standard |
Added examples for roaming status retrieval, updated API definitions to fix validation warnings, fixed CloudEvent schema type declaration, clarified LastStatusTime schema description, and deleted redundant API Readiness Checklists.
hdamker
left a comment
There was a problem hiding this comment.
The device-roaming-status-subscriptions CHANGELOG entry doesn't fully describe what changed in GET /subscriptions.
Comparing 0.8.0 (last released, in r1.2) to 0.9.0-rc.1, the response body for GET /subscriptions changed from a plain array of Subscription to a wrapper object { subscriptions: [...], pagination: {...} }, and the operation gained page/perPage query parameters plus X-Total-Count / X-Total-Pages / Link response headers. This came in via #78 ("Update API definitions to fix CAMARA validation warnings and hints").
Two things to fix in CHANGELOG-r2.md:
- Changed already lists #78 ("Update API definitions to fix CAMARA validation warnings and hints"), but only as that generic one-liner. Please expand it to spell out what actually changed for consumers:
GET /subscriptionsnow supports pagination — newpage/perPagequery parameters, newX-Total-Count/X-Total-Pages/Linkresponse headers, and the response body changed from a bare array to a{ subscriptions: [...], pagination: {...} }object. - Breaking changes is currently
N/A. The response-shape change above is breaking for any consumer of 0.8.0 (bare array → wrapped object). Sincedevice-roaming-status-subscriptionsis still pre-public (0.x), this is allowed without a major bump — but the release documentation rules ask that breaking changes be listed both under Breaking changes and under their normal category (here, Changed), not markedN/A.
|
Beyond the previous comment on the CHANGELOG I have created #93 - not blocking for the first rc, but should be addressed and provided in a second rc. |
fedfe13
hdamker
left a comment
There was a problem hiding this comment.
Looks good now from ReleaseManagement perspective, thanks @eric-murray
Release Review: r2.1 rc
This PR finalizes the reviewable release content for the active snapshot.
Edit and review this PR before merging it into the release snapshot. After Codeowner and Release Management approval, merging this PR creates the draft release.
Release contents
0.9.0-rc.10.8.01.2.0-rc.31.1.0Dependencies: Commonalities r4.3, ICM r4.2
Codeowner Actions
Tick each box once done. Release Management review starts when all three boxes are ticked.
Update the CHANGELOG
What to do:
Document deferred validation warnings (and hints)
What to do:
The release is ready for Release Management review
Check that:
Tick this box to confirm readiness and to start the Release Management review.
Release Management Actions
Required release assets per API status
public
public
M = Mandatory, O = Optional — Full documentation
Valid next actions for codeowners
/discard-snapshot <reason>in the Release Issue to discard this snapshot, return toplanned, and update content onmainSnapshot:
r2.1-9be6fb2