Skip to content

[Changed] Make lastChecked property nullable and add examples #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eric-murray merged 7 commits into from
Jul 31, 2026
Merged

[Changed] Make lastChecked property nullable and add examples #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9f70fd7
Make lastChecked property nullable and add examples
eric-murray Jun 16, 2026
7c73867
Merge branch 'camaraproject:main' into eric-murray-patch-3
eric-murray Jul 29, 2026
12f8224
Merge branch 'camaraproject:main' into eric-murray-patch-3
eric-murray Jul 30, 2026
ad8fe33
Allow lastChecked to be null or a past date-time
eric-murray Jul 30, 2026
14da362
Allow lastChecked to be null or a valid date-time
eric-murray Jul 30, 2026
e33a24a
Update lastChecked property validation in feature file to allow null
eric-murray Jul 30, 2026
5ac5e50
Allow lastChecked to be null in response validation
eric-murray Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions code/API_definitions/device-identifier.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,15 @@
tac: "49015420"
model: "3110"
manufacturer: "Nokia"
Successful Identifier Retrieval With Null lastChecked Field:
description: Device identifier has been successfully retrieved but the API provider has no information on when that information was last confirmed to be correct
value:
lastChecked: null
imeisv: "4901542032375180"
imei: "490154203237518"
tac: "49015420"
model: "3110"
manufacturer: "Nokia"
Successful Identifier Retrieval With Device Disambiguation:
description: Device identifier has been successfully retrieved when a 2-legged access token and multiple device subscription identifiers were provided
value:
Expand Down Expand Up @@ -442,6 +451,13 @@
tac: "49015420"
model: "3110"
manufacturer: "Nokia"
Successful Type Retrieval With Null lastChecked Field:
description: Device identifier has been successfully retrieved but the API provider has no information on when that information was last confirmed to be correct
value:
lastChecked: null
tac: "49015420"
model: "3110"
manufacturer: "Nokia"
Successful Type Retrieval With Device Disambiguation:
description: Device type has been successfully retrieved when a 2-legged access token and multiple device subscription identifiers were provided
value:
Expand Down Expand Up @@ -472,6 +488,11 @@
value:
lastChecked: "2024-02-20T10:41:38.657Z"
ppid: "b083f65ccdad365d7489fff24b6d5074b30c12b6d81db3404d25964ffd908813"
Successful PPID Retrieval With Null lastChecked Field:
description: Device identifier has been successfully retrieved but the API provider has no information on when that information was last confirmed to be correct
value:
lastChecked: null
ppid: "b083f65ccdad365d7489fff24b6d5074b30c12b6d81db3404d25964ffd908813"
Successful PPID Retrieval With Device Disambiguation:
description: Device PPID has been successfully retrieved when a 2-legged access token and multiple device subscription identifiers were provided
value:
Expand Down Expand Up @@ -503,6 +524,11 @@
value:
lastChecked: "2024-02-20T10:41:38.657Z"
match: true
Successful Match With Null lastChecked Field:
description: Device identifier match has been successfully determined but the API provider has no information on when this information was last confirmed to be correct
value:
lastChecked: null
match: true
Successful Non-Match:
description: Device identifier does not match when the device subscription was identified by a 3-legged access token or single device subscription identifier
value:
Expand Down Expand Up @@ -648,8 +674,11 @@
lastChecked:
description: |
Date and time that the information was last confirmed by the mobile operator to be correct. It must follow [RFC 3339](https://datatracker.ietf.org/doc/html/rfc3339#section-5.6) and must have time zone.
allOf:
- $ref: "../common/CAMARA_common.yaml#/components/schemas/DateTime"
type: string
format: date-time
maxLength: 64
nullable: true
example: "2018-04-05T17:31:00Z"

DeviceIdentifier:
description: |
Expand Down Expand Up @@ -680,12 +709,12 @@
pattern: ^[0-9]{8}$
description: IMEI TAC of the device
example: "49015420"
model:

Check notice on line 712 in code/API_definitions/device-identifier.yaml

View workflow job for this annotation

GitHub Actions / validation / Validate

String has no format/pattern/enum 

[S-313] Schema of type string should specify a format, pattern, enum, or const. | Suggestion: Acceptable if free-form field or implementation-dependent — no fix needed.
type: string
maxLength: 32
description: Model of the device
example: "3110"
manufacturer:

Check notice on line 717 in code/API_definitions/device-identifier.yaml

View workflow job for this annotation

GitHub Actions / validation / Validate

String has no format/pattern/enum 

[S-313] Schema of type string should specify a format, pattern, enum, or const. | Suggestion: Acceptable if free-form field or implementation-dependent — no fix needed.
type: string
maxLength: 32
description: Manufacturer of the device
Expand Down
20 changes: 10 additions & 10 deletions code/Test_definitions/device-identifier-matchIdentifier.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Feature: Camara Mobile Device Identifier API, vwip - Operation: matchIdentifier
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.match" exists and is true
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imei" does not exist
And the response property "$.imeisv" does not exist
And the response property "$.tac" does not exist
Expand All @@ -78,7 +78,7 @@ Feature: Camara Mobile Device Identifier API, vwip - Operation: matchIdentifier
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.match" exists and is true
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imei" does not exist
And the response property "$.imeisv" does not exist
And the response property "$.tac" does not exist
Expand All @@ -98,7 +98,7 @@ Feature: Camara Mobile Device Identifier API, vwip - Operation: matchIdentifier
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.match" exists and is false
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imei" does not exist
And the response property "$.imeisv" does not exist
And the response property "$.tac" does not exist
Expand All @@ -119,7 +119,7 @@ Feature: Camara Mobile Device Identifier API, vwip - Operation: matchIdentifier
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.match" exists and is true
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imei" does not exist
And the response property "$.imeisv" does not exist
And the response property "$.tac" does not exist
Expand All @@ -140,7 +140,7 @@ Feature: Camara Mobile Device Identifier API, vwip - Operation: matchIdentifier
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.match" exists and is false
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imei" does not exist
And the response property "$.imeisv" does not exist
And the response property "$.tac" does not exist
Expand All @@ -162,7 +162,7 @@ Feature: Camara Mobile Device Identifier API, vwip - Operation: matchIdentifier
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.match" exists and is true
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imei" does not exist
And the response property "$.imeisv" does not exist
And the response property "$.tac" does not exist
Expand All @@ -184,7 +184,7 @@ Feature: Camara Mobile Device Identifier API, vwip - Operation: matchIdentifier
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.match" exists and is false
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imei" does not exist
And the response property "$.imeisv" does not exist
And the response property "$.tac" does not exist
Expand All @@ -204,7 +204,7 @@ Feature: Camara Mobile Device Identifier API, vwip - Operation: matchIdentifier
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.match" exists and is false
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imei" does not exist
And the response property "$.imeisv" does not exist
And the response property "$.tac" does not exist
Expand All @@ -230,7 +230,7 @@ Feature: Camara Mobile Device Identifier API, vwip - Operation: matchIdentifier
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.match" exists and is true
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imei" does not exist
And the response property "$.imeisv" does not exist
And the response property "$.tac" does not exist
Expand All @@ -256,7 +256,7 @@ Feature: Camara Mobile Device Identifier API, vwip - Operation: matchIdentifier
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.match" exists and is true
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imei" does not exist
And the response property "$.imeisv" does not exist
And the response property "$.tac" does not exist
Expand Down
14 changes: 7 additions & 7 deletions code/Test_definitions/device-identifier-retrieveIdentifier.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Feature: Camara Mobile Device Identifer API, vwip - Operation: retrieveIdentifie
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.imei" exists and is equal to IMEI1
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imeisv", if present, is equal to IMEISV1
And the response property "$.tac", if present, is equal to TAC1
And the response property "$.manufacturer", if present, is equal to MANUFACTURER1
Expand All @@ -69,7 +69,7 @@ Feature: Camara Mobile Device Identifer API, vwip - Operation: retrieveIdentifie
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.imei" exists and is equal to IMEI1
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imeisv", if present, is equal to IMEISV1
And the response property "$.tac", if present, is equal to TAC1
And the response property "$.manufacturer", if present, is equal to MANUFACTURER1
Expand All @@ -88,7 +88,7 @@ Feature: Camara Mobile Device Identifer API, vwip - Operation: retrieveIdentifie
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.imei" exists and is equal to IMEI1
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imeisv", if present, is equal to IMEISV1
And the response property "$.tac", if present, is equal to TAC1
And the response property "$.manufacturer", if present, is equal to MANUFACTURER1
Expand All @@ -106,7 +106,7 @@ Feature: Camara Mobile Device Identifer API, vwip - Operation: retrieveIdentifie
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.imei" exists and is equal to IMEI1
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imeisv", if present, is equal to IMEISV1
And the response property "$.tac", if present, is equal to TAC1
And the response property "$.manufacturer", if present, is equal to MANUFACTURER1
Expand All @@ -124,7 +124,7 @@ Feature: Camara Mobile Device Identifer API, vwip - Operation: retrieveIdentifie
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.imei" exists and is equal to IMEI1
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imeisv", if present, is equal to IMEISV1
And the response property "$.tac", if present, is equal to TAC1
And the response property "$.manufacturer", if present, is equal to MANUFACTURER1
Expand All @@ -142,7 +142,7 @@ Feature: Camara Mobile Device Identifer API, vwip - Operation: retrieveIdentifie
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.imei" exists and is equal to IMEI2
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imeisv", if present, is equal to IMEISV2
And the response property "$.tac", if present, is equal to TAC2
And the response property "$.manufacturer", if present, is equal to MANUFACTURER2
Expand All @@ -160,7 +160,7 @@ Feature: Camara Mobile Device Identifer API, vwip - Operation: retrieveIdentifie
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response header "Content-Type" is "application/json"
And the response property "$.imei" exists and is equal to IMEI2
And the response property "$.lastChecked" exists and is a valid date-time in the past
And the response property "$.lastChecked" exists and is either a valid date-time in the past, or is null
And the response property "$.imeisv", if present, is equal to IMEISV2
And the response property "$.tac", if present, is equal to TAC2
And the response property "$.manufacturer", if present, is equal to MANUFACTURER2
Expand Down
Loading