fix: align test feature files with API definition operationIds - #148
Merged
tlohmar merged 3 commits intoAug 10, 2026
Merged
Conversation
Fixes camaraproject#143: corrects operationId mismatches in When steps and scenario tags for dedicated-network-accesses.feature and dedicated-network-areas.feature, fixes duplicate _06_ numbering, fixes schema reference to CreateAccessRequest, and adds missing x-correlator assertions and listDevices scenario.
jimfengjinhua
requested review from
PeterKovacs2,
carlosromerog,
eric-murray and
tlohmar
as code owners
August 7, 2026 12:46
tlohmar
reviewed
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Fixes for issue #138 and #143
dedicated-network-accesses.feature — operationId alignment (6 mismatches):
listNetworkAccesses→listAccesses(tags + When steps)createNetworkAccess→createAccess(tags + When steps)readNetworkAccess→readAccess(tags + When steps)deleteNetworkAccess→deleteAccess(tags + When steps)addDevicesRequest→addDevicesToAccess(When steps)removeDevicesRequest→removeDevicesFromAccess(When steps)dedicated-network-areas.feature — operationId alignment (2 mismatches):
retrieveServiceAreas→retrieveNetworkServiceAreas(When steps)readServiceArea→readNetworkServiceArea(When steps)dedicated-network-areas.feature — duplicate numbering:
_06_scenario renumbered to_07_; error scenarios renumbered accordingly (_08_, etc.)dedicated-network-areas.feature — incorrect tag prefix:
@areas_retrieveServiceAreas_04_...→@dedicated_network_areas_retrieveNetworkServiceAreas_08_...@areas_readServiceArea_02_...→@dedicated_network_areas_readNetworkServiceArea_02_...@areas_readServiceArea_03_...→@dedicated_network_areas_readNetworkServiceArea_03_...Additional fixes found during review
dedicated-network-accesses.feature:
addDeviceAccess→addDevicesToAccess(tag didn't mirror operationId)removeNetworkaccess→removeDevicesFromAccess(tag didn't mirror operationId)CreateNetworkAccess→CreateAccessRequest(non-existent schema)listDevicesscenario (operationId existed in API but had no test coverage)dedicated-network-areas.feature:
retrieveServiceAreas→retrieveNetworkServiceAreas(full operationId alignment in tags, not just When steps)readServiceAreas→readNetworkServiceArea(plural→singular + full operationId)$.codeassertions to error scenariosWhich issue(s) this PR fixes:
Fixes #138 #143
Special notes for reviewers:
This PR includes a few extra changes for some issues that were not mentioned in the original issue #138 and #143.
Changelog input
Additional documentation