Skip to content

fix: resolve CAMARA validation warnings - #229

Merged
rartych merged 1 commit into
camaraproject:mainfrom
rartych:validation-fix
Jul 28, 2026
Merged

fix: resolve CAMARA validation warnings#229
rartych merged 1 commit into
camaraproject:mainfrom
rartych:validation-fix

Conversation

@rartych

@rartych rartych commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

What type of PR is this?

  • correction

What this PR does / why we need it:

Fixes all warnings reported by the CAMARA Validation workflow (advisory profile):

  • P-026: Added mandatory info.description templates with proper BEGIN/END markers: authorization-and-authentication, additional-error-responses, request-body-strictness, and identifying-phone-number-from-access-token
  • S-309 / S-031: Added maxItems: 5 and description to CallForwardingSignal array items
  • S-011 / S-310 / S-311 / S-312: Replaced local inline definitions of XCorrelator, ErrorInfo, and PhoneNumber schemas with $ref to ../common/CAMARA_common.yaml, which already provides all required constraints (format, minimum, maximum, maxLength, description)
  • S-021: Converted tag names to Title Case (Unconditional Call Forwarding Information Retrieval, Call Forwarding Information Retrieval)
  • P-032: Deleted obsolete call-forwarding-signal-API-Readiness-Checklist.md file

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

XCorrelator, ErrorInfo, and PhoneNumber schemas are now referenced directly from code/common/CAMARA_common.yaml instead of being redefined locally, ensuring alignment with Commonalities r4.3.

Changelog input

Fixed CAMARA validation warnings: add mandatory info.description templates, add array constraints to CallForwardingSignal, reference XCorrelator/ErrorInfo/PhoneNumber from CAMARA_common.yaml, fix tag Title Case, remove obsolete API Readiness Checklist

- P-026: Add mandatory info.description templates with BEGIN/END markers
  (authorization-and-authentication, additional-error-responses,
  request-body-strictness, identifying-phone-number-from-access-token)
- S-309/S-031: Add maxItems: 5 and description to CallForwardingSignal array items
- S-011/S-310/S-311/S-312: Replace local XCorrelator, ErrorInfo and PhoneNumber
  schemas with \ to ../common/CAMARA_common.yaml
- S-021: Convert tag names to Title Case
- P-032: Delete obsolete API Readiness Checklist file

@bigludo7 bigludo7 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks a lot @rartych

@rartych
rartych merged commit 74ec8c5 into camaraproject:main Jul 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants