v1.3: qualify Retina, input, and filesystem paths - #69
Merged
Merged
Conversation
cam11505
marked this pull request as ready for review
September 27, 2026 02:53
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source identification can raise a raw exception on cyclic symlinks, and missing/unsupported folder requests can escape the UI callback. Translate path-resolution failures to the existing content error and validate source identity before resetting the current reader.
Issue #48 qualification adds real Qt offscreen DPR 1/2/3 tests, synthetic screen-change/trackpad events, PDF render-size/cache/opaque-page regressions, Unicode/nested/resume/symlink paths, and a native macOS APFS/APFSX mounted-volume plus detach lane. Existing Windows/Ubuntu tests and macOS packaged app checks remain required.
Baseline:
v1.2.2/bb0197b0291707287517ba8bdfc3a10ce1ad1149; prerequisite main:073a74446dd3a02cf030d2e214dd5292484c98b7(PR #68).Final head:
dc9ea1d06e0b2739fb4342e892848c92d901f9dd. All automatic checks passed for this exact head. The tested PR merge commitca364eb6f026ba92b7edea9a438d2d0781d12190has the same tree as this head (8c96bd9cc3637a77938773569e1ac4c3853d8fec).Verification:
226 passed, 4 skipped; focused:16 passed, 3 skipped(Windows symlink permissions and dedicated volume lane). Ruff check/format and diff checks passed.18 passed, 1 skipped; the skipped volume test passed independently on APFS and Case-sensitive APFS. Both actual detach cases returned inaccessible. Final-head evidence downloaded and checked.Physical Retina/external-display/trackpad/fullscreen and physical removable-volume QA are explicitly deferred by the user on 2026-09-27 because no physical Mac is available. They are not reported as passed; the future validation checklist remains in
docs/MACOS_RETINA_PATHS.md. This removes the physical-QA blocker. After this PR merges, #49 may proceed; mandatory official signing/notarization/staple/automated release gates are unchanged.Closes #48