Feature/rework push oid checking#250
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09886249d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if !s.presentInScope[oid] { | ||
| continue | ||
| } |
There was a problem hiding this comment.
When the new scoped endpoint reports an OID as missing in this project, this continue prevents loading any non-scoped checksum matches, so existingByHash[oid] stays empty. In that scenario the findReusableRecord path below never runs; a branch containing a pointer with no local payload but with a reusable object in another scope gets skipped as unavailable and the Git ref is still pushed with no metadata/payload for the target scope. Please keep a legacy/global lookup for missing-in-scope OIDs, or otherwise populate reusable records, before deciding to skip/register-upload.
Useful? React with 👍 / 👎.
1 participant
change push cmd oid checking to use a faster syfon based existence check instead of the base bulk row fetch