Chore/reconcile upgrade#1410
Open
nss10 wants to merge 31 commits into
Open
Conversation
lbeckman314
added
the
safe to test
…/reconcile_upgrade and rename updated monolith reconcile function as `reconcile_monolith`.
…k in Running as System error
lbeckman314
added a commit
that referenced
this pull request
Jun 22, 2026
Signed-off-by: Liam Beckman <lbeckman314@gmail.com>
lbeckman314
approved these changes
Jun 26, 2026
lbeckman314
left a comment
lbeckman314
left a comment
Contributor
There was a problem hiding this comment.
Approved in PR #1438 to allow Integration Tests to run!
8 tasks
lbeckman314
modified the milestones:
Gen3Workflow Production-Ready Support,
Helm Chart v0.1.99-rc.39
matthewpeterkort
pushed a commit
that referenced
this pull request
Jul 8, 2026
* Add reconcile_modular draft code * Improve reconciler modular code * switch to reconclie_modular * Add Debug logs for PVC deletiojn * handle reconciler when job restarts happen * cause exec_error to maje a sys_error * Revert exec_err to sys_err, exec pod crash is no longer sys_err if job backof limit is not exhausted * Remove lastAttempt check * Remove TTLSecondsAfterFinished from worker pod. * Set quay to cdis * Remove old code and WIP comments * TTLSecondsAfterFinished to worker job removed. Jobcleanup takes care of this. * Print SQL logs to identify bug * Add state filter in ListTasks * Add state in the ListTasks tests * Remove sql debug logs * Add updated reconcile_monolith and modular reconciler * Retry pods when job backoff limit is not reached yet * Fix compiler error in reconciler_monolith * Replace inner function to class level function and mark completed task in Running as System error * Remove tests linked to TTLSecondsAfterFinished * Update backofflimit check when task is in terminal state. * task: Revert cancel response coe back to 200 * Update integration_tests_on_kind.yaml * Fix isJobMarkedAsFailed for tasks that are completed. * Add debug logs to understand the jobConditions for successful tasks * isJobDone * Final commits and comment improvements before making PR. * debug: Integration tests * ci: re-trigger integration tests * ci: pin gen3-code-vigil to correct green commit 69c620a 891ea9e was the funnel merge commit, not gen3-code-vigil, so the checkout failed with 'not our ref'. 69c620a (Gen3SDK Tests #558) is the gen3-code-vigil commit from the last green run, and its conftest.py predates the get_navigation_url() call that crashes on master. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Assisted-by: Claude Code:claude [Claude Code] * debug: CI * fix: Cleanup code Signed-off-by: Liam Beckman <lbeckman314@gmail.com> * task: Revert changes to better match PR #1410 Signed-off-by: Liam Beckman <lbeckman314@gmail.com> * chore: Unpin integration tests action --------- Signed-off-by: Liam Beckman <lbeckman314@gmail.com> Co-authored-by: Sai Shanmukha <nss10@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of Changes
Checklist