Skip to content

Fix Ingress class detection for github-repo-registrations-eventsource#99

Merged
bwalsh merged 3 commits into
feature/ingressfrom
copilot/sub-pr-92-again
Nov 25, 2025
Merged

Fix Ingress class detection for github-repo-registrations-eventsource#99
bwalsh merged 3 commits into
feature/ingressfrom
copilot/sub-pr-92-again

Conversation

Copilot AI commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

github-repo-registrations-eventsource ingress showed no CLASS in kubectl get ingress -A because it used the deprecated kubernetes.io/ingress.class annotation instead of spec.ingressClassName.

Changes

  • eventsource-github-from-repo-registrations.yaml: Replace deprecated annotation with spec.ingressClassName
  • ingress-authz.yaml: Add | quote to ingressClassName for consistent YAML parsing

Before:

metadata:
  annotations:
    kubernetes.io/ingress.class: {{ .Values.events.github.webhook.ingress.className | default "nginx" | quote }}
spec:
  rules:

After:

metadata:
  # no ingress class annotation
spec:
  ingressClassName: {{ .Values.events.github.webhook.ingress.className | default "nginx" | quote }}
  rules:

Once redeployed, the ingress controller will properly detect and assign an ADDRESS to the resource.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits November 25, 2025 15:55
…ClassName instead of deprecated annotation

Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>

Copilot AI commented Nov 25, 2025

Copy link
Copy Markdown
Contributor Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • argoproj.github.io
    • Triggering command: /usr/local/bin/helm helm repo add argo REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add authz-aware ingress overlay for multi-tenant UIs and APIs Fix Ingress class detection for github-repo-registrations-eventsource Nov 25, 2025
Copilot AI requested a review from bwalsh November 25, 2025 15:58
@bwalsh
bwalsh marked this pull request as ready for review November 25, 2025 16:01
@bwalsh
bwalsh merged commit 540c3d7 into feature/ingress Nov 25, 2025
@bwalsh
bwalsh deleted the copilot/sub-pr-92-again branch November 25, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants