Repository navigation
Merged
Conversation
…eside Node instead of npm-cli.js in node_modules
… has no npm symlink (#1664)
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Author
Review ledgerRound 1: 9f26738 {"findings":[]}Written by an agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1664
Status
Implement: done (4/4 green) Review: round 1 passed, 0 findings Hardware: n/a Gate: running
Done when:
npmruns fromnode_modules/npm/bin/npm-cli.jsbeside Node when that file exists, else today's realpath ofnpm(src/ports/npm-cli.ts#script; testsrc/ports/npm-cli.test.ts) — unit testsrc/ports/npm-cli.test.tsgreen, probed by the audit and the code reviewsimlock update --jsonreach npm. Evidence on Windows 11, Node 22.23.5, SIMLOCK_HOME=D:\sv\bug1664 at 9f26738:daemon startlog has no "Latest Simlock version check failed";node dist\cli\main.js update --jsonreturned{"upToDate":true,"resolved":"0.8.0","latestVersion":"0.8.0","started":false,...}with nothing installed. Home and worktree removed. — checked on DesktopWindows by the buildAssumptions
none
Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 1.2M.
Runs: 6. Cost USD: 1.059. Agent seconds: 961.
Assessment: complete
Written by an agent.