Skip to content

fix(ports): npm runs from node_modules beside Node when the installer has no npm symlink - #1673

Merged
V3RON merged 2 commits into
mainfrom
bug/1664
Nov 17, 2026
Merged

V3RON merged 2 commits into
mainfrom
bug/1664

Conversation

@V3RON

@V3RON V3RON commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1664

Status

Implement: done (4/4 green) Review: round 1 passed, 0 findings Hardware: n/a Gate: running

Done when:

  • npm runs from node_modules/npm/bin/npm-cli.js beside Node when that file exists, else today's realpath of npm (src/ports/npm-cli.ts #script; test src/ports/npm-cli.test.ts) — unit test src/ports/npm-cli.test.ts green, probed by the audit and the code review
  • Windows: the daemon's version check and simlock update --json reach npm. Evidence on Windows 11, Node 22.23.5, SIMLOCK_HOME=D:\sv\bug1664 at 9f26738: daemon start log has no "Latest Simlock version check failed"; node dist\cli\main.js update --json returned {"upToDate":true,"resolved":"0.8.0","latestVersion":"0.8.0","started":false,...} with nothing installed. Home and worktree removed. — checked on DesktopWindows by the build

Assumptions

none

Review

Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 1.2M.
Runs: 6. Cost USD: 1.059. Agent seconds: 961.
Assessment: complete

Written by an agent.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@V3RON

V3RON commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: 9f26738

Runs: 6. Cost USD: 1.059. Agent seconds: 961.
Tokens input 89, output 19885, cache read 1432459, cache write 223056.
- build implementer: claude-sonnet-5-5 350 s $0.2085
- audit implementer: claude-sonnet-5-5 358 s $0.1352
- review 1 reviewer: claude-sonnet-5-5 165 s $0.2184
- review 1 spec: claude-sonnet-5-5 13 s $0.0951
- review 1 code both: claude-opus-5-5 60 s $0.3181
- review 1 claims: claude-sonnet-5-5 15 s $0.0837
Finding outcomes: {}. Classes: {}.
{"findings":[]}

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review November 17, 2026 15:16
@V3RON
V3RON merged commit 57f6382 into main Nov 17, 2026
65 checks passed
@V3RON
V3RON deleted the bug/1664 branch November 17, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On Windows the daemon's latest-version check runs npm's shell wrapper with node and fails at every start

1 participant