Skip to content

feat(ios): slim worker include and exclude lists of single services - #1655

Open
V3RON wants to merge 20 commits into
feature/1644-adrfrom
task/1650
Open

V3RON wants to merge 20 commits into
feature/1644-adrfrom
task/1650

Conversation

@V3RON

@V3RON V3RON commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1650

Status

Implement: done (5/5 green) Review: passed (rounds 1, 2, fix-checks at 5a0d833 and 5d9cfc6) Hardware: unavailable (10.2 GiB free disk, lane needs 15) Gate: not run, parked needs-hardware
Next: the maintainer runs the B6 slow-lane line on a Mac with 15 GiB free, then the stack #1646 -> #1655 merges

Assumptions

none

Done when

  • pnpm test:changed passes, with the B1–B5 cases above — the implementer's runs (5784 tests, then the src/drivers/ios and src/docs-manuals.test.ts files after each fix); one failure outside the diff is flaky: lease-files and relay-gateway-files tests answer 422 instead of 201 on a clean base #1613 (flaky).
  • The website build and its HTTP API check pass (definition.ts changes) — run by the build and the audit.
  • On a Mac with a real simulator, the B6 cases pass in e2e/slow-ios-slim.test.ts, run through scripts/slow-e2e.sh e2e/slow-ios-slim.test.ts — not run: the lane refused this machine (10.2 GiB free disk, needs 15).
  • src/drivers/ios/AGENTS.md states the precedence, the record and the old-baseline gap; the configuration reference says that categories and exclude turn services off and include keeps them running — verified at the fix-check of 5a0d833 (R5).

Review

Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 5 blocking, 5 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 2 notes.
Rounds: 2. Tokens: 5.1M.
Runs: 16. Cost USD: 6.418. Agent seconds: 2641.

Assessment: complete

Completion conditions

  • A worker with ios.slim.exclude: ["com.apple.diagnosticd"] and categories: [] grants a slim lease a slim device in which no diagnosticd runs (on a Mac, real simulator) — not run: the slow lane refused this machine (disk).
  • A worker with ios.slim.include: ["com.apple.apsd"] and categories unset grants a slim device whose launchctl print-disabled system shows apsd not disabled and every other category label disabled (on a Mac, real simulator) — not run: the slow lane refused this machine (disk).
  • A worker restarted with com.apple.diagnosticd taken out of exclude prepares its surviving idle simulators with diagnosticd on — B2's recorded-name case in slim-named-services.test.ts, probed in review.
  • A config with one name in both lists fails the daemon start with the message of I1 — B1's both-lists case in definition.test.ts, probed in the audit.
  • The configuration reference lists both keys and says that categories and exclude turn services off and include keeps them running — config-reference.test.ts and the reviewed configuration.mdx rows.

Written by an agent.

V3RON added 15 commits November 17, 2026 11:35
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 25 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: a258d984-815b-491c-8468-ac5337bb9f6a
Commits

Reviewing files that changed from the base of the PR and between 6fcfdc5 and 5d9cfc6.

Files selected for processing: 16

  • docs/internal/EVENTS.md
  • e2e/helpers/ios-device-set.ts
  • e2e/slow-ios-slim.test.ts
  • src/core/config-role-checks.ts
  • src/core/config-types.ts
  • src/core/config.ts
  • src/drivers/ios/AGENTS.md
  • src/drivers/ios/definition.test.ts
  • src/drivers/ios/definition.ts
  • src/drivers/ios/index-save-source-lifecycle.test.ts
  • src/drivers/ios/slim-boot.ts
  • src/drivers/ios/slim-labels.ts
  • src/drivers/ios/slim-named-services.test.ts
  • src/drivers/ios/test-slim.ts
  • website/src/content/docs/docs/reference/configuration.mdx
  • website/src/content/docs/docs/using-devices/choosing-a-device.mdx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@V3RON

V3RON commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: 1597ae7
Round 2: a7eaf81
Round fix-check: 5a0d833
Round fix-check: 5d9cfc6

Runs: 16. Cost USD: 6.418. Agent seconds: 2641.
Tokens input 496, output 154985, cache read 15113565, cache write 873163.
- build implementer: claude-sonnet-5-5 535 s $1.5885
- audit implementer: claude-sonnet-5-5 234 s $0.3514
- review 1 reviewer: claude-sonnet-5-5 385 s $0.3776
- review 1 spec: claude-sonnet-5-5 21 s $0.1563
- review 1 code both: claude-opus-5-5 289 s $1.2202
- review 1 claims: claude-sonnet-5-5 43 s $0.2101
- fix 1 implementer: claude-sonnet-5-5 110 s $0.3031
- review 2 reviewer: claude-sonnet-5-5 292 s $0.2547
- review 2 code both: claude-opus-5-5 189 s $0.7408
- review 2 claims: claude-sonnet-5-5 21 s $0.101
- fix 2 implementer: claude-sonnet-5-5 168 s $0.2934
- review fix-check reviewer: claude-sonnet-5-5 191 s $0.1989
- review fix-check code-reviewer both: claude-opus-5-5 91 s $0.3847
- hardware hardware-verifier: claude-sonnet-5-5 11 s $0.0469
- fix fix-check implementer: claude-sonnet-5-5 34 s $0.097
- review fix-check reviewer: claude-sonnet-5-5 27 s $0.0934
Finding outcomes: {"fixed":6}. Classes: {"ADR 0060 failed write logged":1,"ADR 0083 4 nothing off grants full":1,"documentation 7":1,"issue Done when manual states precedence":1,"spec I2 skipped logged as today":1,"testing 10":1}.
{"findings":[{"id":"R1","role":"code","class":"ADR 0083 4 nothing off grants full","outcome":"fixed","path":"src/drivers/ios/slim-boot.ts","round":"1","fix":"a7eaf81b"},{"id":"R2","role":"code","class":"spec I2 skipped logged as today","outcome":"fixed","path":"src/drivers/ios/slim-boot.ts","round":"1","fix":"a7eaf81b"},{"id":"R3","role":"code","class":"testing 10","outcome":"fixed","path":"src/drivers/ios/slim-named-services.test.ts","round":"1","fix":"a7eaf81b"},{"id":"R4","role":"claims","class":"documentation 7","outcome":"fixed","path":"src/drivers/ios/AGENTS.md","round":"1","fix":"a7eaf81b"},{"id":"R5","role":"code","class":"issue Done when manual states precedence","outcome":"fixed","path":"src/drivers/ios/AGENTS.md","round":"2","fix":"5a0d833f"},{"id":"R6","role":"code","class":"ADR 0060 failed write logged","outcome":"fixed","path":"src/drivers/ios/slim-boot.ts","round":"2","fix":"5a0d833f"}]}

Written by an agent.

@V3RON

V3RON commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Review notes

Not blocking, not verified. Each is one reviewer's claim.

  • claims: src/drivers/ios/AGENTS.md "Nothing off: full, no readback" was not true when a lease's --except keeps categories; reworded in 5a0d833 ("Nothing written off and no kept category").
  • claims: src/drivers/ios/AGENTS.md the trim to fit the 8000-character cap dropped two untested hardware observations from Known gaps ("a silent iPhone keeps its last picture", "the source ending after the first picture").

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review November 17, 2026 11:17
@V3RON V3RON added the needs-hardware PR parked: a Done when line needs a real simulator or emulator run. label Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-hardware PR parked: a Done when line needs a real simulator or emulator run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slim: worker include and exclude lists of single services

1 participant