Repository navigation
fix(android): stop the emulator's qemu child too when killing it on Windows #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
V3RON
merged 10 commits into
callstackincubator:main
from
leonardoxr:fix/windows-emulator-tree-kill
Nov 17, 2026
+178
−18
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ac6aed8
fix(android): stop the emulator's qemu child too when killing it on W…
leonardoxr b5eef75
fix(android): kill the process tree only for the emulator on Windows
leonardoxr f37f2b7
fix(android): keep the driver manual in budget and test only the emul…
leonardoxr 2cc2877
test(android): check every emulator launch asks for the tree kill
leonardoxr 247a5da
merge main into fix/windows-emulator-tree-kill
leonardoxr 6490ada
refactor(ports): move the tree-kill choice out of spawn
leonardoxr e5b2b81
merge main into fix/windows-emulator-tree-kill
leonardoxr 81439be
merge main into fix/windows-emulator-tree-kill
V3RON 3113cab
fix(ports): killChildren changes nothing off Windows, so a child's ex…
V3RON 37ff310
Merge remote-tracking branch 'origin/main' into fix/windows-emulator-…
V3RON File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stop the parent with
-ErrorAction SilentlyContinue, as the child loop already does.Under
$ErrorActionPreference = 'Stop',Stop-Processon a PID that has already exited raises a terminating error. If emulator.exe exits after$childrenis built and before line 49 runs, the script ends there. The child loop never runs, so qemu is not stopped. The fallback then kills only the parent, and only while it is still running, so the children stay alive.Suggested fix
Committable suggestion